STYLE: Remove CMake checks on old MSVC versions (before version 1910)#3335
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Mar 25, 2022
Conversation
ITKv5.3 requires at least MSVC version 1910 (Visual Studio 2017) now, so it is no longer useful to check if `MSVC_VERSION GREATER_EQUAL 1600`, or `1800`, or `MSVC_VERSION GREATER 1310`. Checks on `CMAKE_COMPILER_2005` (Visual Studio 2005) are also obsolete. Follow-up to: pull request InsightSoftwareConsortium#2563 commit 4e812d6 "COMP: Require compiler versions that support C++14" (merged on on 3 June 2021)
github-actions
bot
added
area:Core
dzenanz
approved these changes
Mar 24, 2022
hjmjohnson
approved these changes
Mar 25, 2022
hjmjohnson
approved these changes
Mar 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ITKv5.3 requires at least MSVC version 1910 (Visual Studio 2017) now, so it is no longer useful to check if
MSVC_VERSION GREATER_EQUAL 1600, or1800, orMSVC_VERSION GREATER 1310.Checks on
CMAKE_COMPILER_2005(Visual Studio 2005) are also obsolete.Follow-up to pull request #2563 commit 4e812d6 "COMP: Require compiler versions that support C++14" (merged on 3 June 2021)