ENH: Upgrade ITK from C++11 to C++14 by N-Dekker · Pull Request #2563 · InsightSoftwareConsortium/ITK

N-Dekker · 2021-05-31T13:56:09Z

Follow-up to commit babb677
"COMP: Enforce building ITK with C++11", Hans Johnson (@hjmjohnson), 19 January 2018

Discussion item: https://discourse.itk.org/t/may-we-start-using-c-14-at-the-master-branch/4172

dzenanz

I like rolling version updates like this.

jhlegarreta · 2021-06-01T13:41:59Z

The requirements in the ITK SW Guide (section Configuring and Building ITK) will need to be updated accordingly, and revise if specificities about the Implementation Language still hold.

dzenanz

Mostly looks good

Following pull request InsightSoftwareConsortium/ITK#2563 "ENH: Upgrade ITK from C++11 to C++14" Suggested by Jon Haitz Legarreta Gorroño

Follow-up to commit babb677 "COMP: Enforce building ITK with C++11", Hans Johnson, 19 January 2018

jhlegarreta

I do not have a strong opinion on this, since I do not use ITK in my daily work (and henc eI have not voiced my opinion in discourse), but in the past I have seen some resistance to such changes in some contexts (e.g. people maintaining an application that depends on ITK like to see long time support).

Relevant to this, it may be worthwhile revisiting the deprecation cycle statement in https://github.com/InsightSoftwareConsortium/ITKSoftwareGuide/blob/master/SoftwareGuide/Latex/Introduction/Installation.tex#L27. I do not know if this change complies with that. If it does, it is a strong argument for it.

N-Dekker · 2021-06-01T14:29:32Z

@jhlegarreta

in the past I have seen some resistance to such changes in some contexts (e.g. people maintaining an application that depends on ITK like to see long time support).

Thanks for your very relevant comment, Jon. Generally speaking there are always users who want to stick to the old standards, and those who prefer the latest and greatest. To me, a move to C++14 feels like a compromise, as it is quite an old standard revision already. C++17, which has quite some more interesting features, seems generally available for a while already. But then the relevant question is of course, whether there are still ITK users who would want to keep up-to-date with the latest ITK version, while requiring an older C++ version.

dzenanz · 2021-06-01T14:39:44Z

VS2015 now has some extended support until 2025, while mainstream support ended in March 2020 (more than a year ago). And since VS2017 and 2019 are compatible with VS2015's CRT, I think it is OK to drop support for VS2015 now.

N-Dekker · 2021-06-01T18:21:30Z

+#  if defined(__clang__) && (__cplusplus < 201402L)
+#    error "Apple LLVM < 5.1 (clang < 3.4) is not supported under ITKv5.3"


It appears that ITK.macOS.Python (Azure.Mac-1622555791099 Darwin-Build4705-PR2563-CXX_STANDARD-from-11-to-14-Python) fails here, because defined(__clang__) && (__cplusplus < 201402L)

At https://open.cdash.org/viewBuildError.php?buildid=7259248

Any suggestion? Is the compiler properly set to C++14 for ITK.macOS.Python?

@N-Dekker this may need to be updated:

ITK/Wrapping/Generators/CastXML/CMakeLists.txt

Lines 220 to 224 in 71bb6a9

if(CMAKE_CXX_EXTENSIONS)

set(_castxml_cc_flags "${_castxml_cc_flags} ${CMAKE_CXX11_EXTENSION_COMPILE_OPTION}")

else()

set(_castxml_cc_flags "${_castxml_cc_flags} ${CMAKE_CXX11_STANDARD_COMPILE_OPTION}")

endif()

Following pull request InsightSoftwareConsortium/ITK#2563 "ENH: Upgrade ITK from C++11 to C++14" Suggested by Jon Haitz Legarreta Gorroño

C++14 is a small extension over C++11, featuring mainly bug fixes and small improvements: https://en.wikipedia.org/wiki/C%2B%2B14 This commit follows ITK pull request InsightSoftwareConsortium/ITK#2563 commit InsightSoftwareConsortium/ITK@daec0fd "ENH: Upgrade ITK from C++11 to C++14" (1 June 2021).

C++14 is a small extension over C++11, featuring mainly bug fixes and small improvements: https://en.wikipedia.org/wiki/C%2B%2B14 This commit follows ITK pull request InsightSoftwareConsortium/ITK#2563 commit InsightSoftwareConsortium/ITK@daec0fd "ENH: Upgrade ITK from C++11 to C++14" (1 June 2021). Follow-up to pull request #123 commit b84ab47 "ENH: Explicitly set CMAKE_CXX_STANDARD to 11", by Kasper Marstal, 8 March 2019

ITKv5.3 requires at least MSVC version 1910 (Visual Studio 2017) now, so it is no longer useful to check if `MSVC_VERSION GREATER_EQUAL 1600`, or `1800`, or `MSVC_VERSION GREATER 1310`. Checks on `CMAKE_COMPILER_2005` (Visual Studio 2005) are also obsolete. Follow-up to: pull request InsightSoftwareConsortium#2563 commit 4e812d6 "COMP: Require compiler versions that support C++14" (merged on on 3 June 2021)

ITKv5.3 requires at least MSVC version 1910 (Visual Studio 2017) now, so it is no longer useful to check if `MSVC_VERSION GREATER_EQUAL 1600`, or `1800`, or `MSVC_VERSION GREATER 1310`. Checks on `CMAKE_COMPILER_2005` (Visual Studio 2005) are also obsolete. Follow-up to: pull request #2563 commit 4e812d6 "COMP: Require compiler versions that support C++14" (merged on on 3 June 2021)

For Apple, ITKv5.3 ("itkCompilerChecks.cmake") requires at least LLVM Clang 3.4 or GCC 5.1. Follow-up to: pull request InsightSoftwareConsortium#2563 commit 4e812d6 "COMP: Require compiler versions that support C++14" (merged on 3 June 2021)

ITKv5.3 ("itkCompilerChecks.cmake") requires at least GCC 5.1. Follow-up to: pull request InsightSoftwareConsortium#2563 commit 4e812d6 "COMP: Require compiler versions that support C++14" (merged on 3 June 2021)

For Apple, ITKv5.3 ("itkCompilerChecks.cmake") requires at least LLVM Clang 3.4 or GCC 5.1. Follow-up to: pull request #2563 commit 4e812d6 "COMP: Require compiler versions that support C++14" (merged on 3 June 2021)

ITKv5.3 ("itkCompilerChecks.cmake") requires at least GCC 5.1. Follow-up to: pull request #2563 commit 4e812d6 "COMP: Require compiler versions that support C++14" (merged on 3 June 2021)

GCC 4 support was dropped with pull request InsightSoftwareConsortium#2563 commit 4e812d6 "COMP: Require compiler versions that support C++14", June 3, 2021

GCC 4 support was dropped with pull request #2563 commit 4e812d6 "COMP: Require compiler versions that support C++14", June 3, 2021

Follow-up to pull request InsightSoftwareConsortium#2563 commit daec0fd "ENH: Upgrade ITK from C++11 to C++14"

Follow-up to pull request InsightSoftwareConsortium#2563 commit 4e812d6 "COMP: Require compiler versions that support C++14" Resources: C++ reference - Compiler support for C++17 https://en.cppreference.com/w/cpp/compiler_support/17 Note that for C++17 "hardware interference size" support, we would need GCC 12 and Clang 15. C++17 Support in GCC https://gcc.gnu.org/projects/cxx-status.html#cxx17 Announcing: MSVC Conforms to the C++ Standard, Ulzii Luvsanbat, May 7th, 2018 https://devblogs.microsoft.com/cppblog/announcing-msvc-conforms-to-the-c-standard/ C++17 Features Supported by Intel C++ Compiler Classic, Last Updated: 09/12/2020 By Anoop Madhusoodhanan Prabha https://www.intel.com/content/www/us/en/developer/articles/news/c17-features-supported-by-c-compiler.html Xcode clang version record, Masayuki Yamaya, December 14, 2022 https://gist.github.com/yamaya/2924292

Follow-up to pull request #2563 commit daec0fd "ENH: Upgrade ITK from C++11 to C++14"

Follow-up to pull request #2563 commit 4e812d6 "COMP: Require compiler versions that support C++14" Resources: C++ reference - Compiler support for C++17 https://en.cppreference.com/w/cpp/compiler_support/17 Note that for C++17 "hardware interference size" support, we would need GCC 12 and Clang 15. C++17 Support in GCC https://gcc.gnu.org/projects/cxx-status.html#cxx17 Announcing: MSVC Conforms to the C++ Standard, Ulzii Luvsanbat, May 7th, 2018 https://devblogs.microsoft.com/cppblog/announcing-msvc-conforms-to-the-c-standard/ C++17 Features Supported by Intel C++ Compiler Classic, Last Updated: 09/12/2020 By Anoop Madhusoodhanan Prabha https://www.intel.com/content/www/us/en/developer/articles/news/c17-features-supported-by-c-compiler.html Xcode clang version record, Masayuki Yamaya, December 14, 2022 https://gist.github.com/yamaya/2924292

github-actions bot added the type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots label May 31, 2021

N-Dekker requested review from blowekamp, dzenanz, hjmjohnson and thewtex May 31, 2021 14:00

dzenanz approved these changes May 31, 2021

View reviewed changes

N-Dekker force-pushed the CXX_STANDARD-from-11-to-14 branch from 4086301 to af772d9 Compare May 31, 2021 16:41

N-Dekker marked this pull request as ready for review May 31, 2021 16:41

N-Dekker changed the title ~~WIP: ENH: Upgrade ITK from C++11 to C++14~~ ENH: Upgrade ITK from C++11 to C++14 May 31, 2021

N-Dekker force-pushed the CXX_STANDARD-from-11-to-14 branch from af772d9 to 0b0ca59 Compare June 1, 2021 08:23

github-actions bot added the type:Enhancement Improvement of existing methods or implementation label Jun 1, 2021

N-Dekker requested a review from dzenanz June 1, 2021 08:24

N-Dekker force-pushed the CXX_STANDARD-from-11-to-14 branch from 0b0ca59 to a1df8f7 Compare June 1, 2021 13:34

github-actions bot added the area:Core Issues affecting the Core module label Jun 1, 2021

dzenanz reviewed Jun 1, 2021

View reviewed changes

Comment thread CMake/itkCompilerChecks.cmake Outdated

N-Dekker added a commit to N-Dekker/ITKSoftwareGuide that referenced this pull request Jun 1, 2021

ENH: Update compiler versions for C++14

fc64bda

Following pull request InsightSoftwareConsortium/ITK#2563 "ENH: Upgrade ITK from C++11 to C++14" Suggested by Jon Haitz Legarreta Gorroño

N-Dekker mentioned this pull request Jun 1, 2021

ENH: Update compiler versions for C++14 InsightSoftwareConsortium/ITKSoftwareGuide#156

Merged

ENH: Upgrade ITK from C++11 to C++14

daec0fd

Follow-up to commit babb677 "COMP: Enforce building ITK with C++11", Hans Johnson, 19 January 2018

N-Dekker force-pushed the CXX_STANDARD-from-11-to-14 branch from a1df8f7 to 5539f55 Compare June 1, 2021 14:02

N-Dekker requested a review from jhlegarreta June 1, 2021 14:05

jhlegarreta reviewed Jun 1, 2021

View reviewed changes

N-Dekker commented Jun 1, 2021

View reviewed changes

seanm reviewed Jun 1, 2021

View reviewed changes

Comment thread CMake/itkCompilerChecks.cmake Outdated

N-Dekker force-pushed the CXX_STANDARD-from-11-to-14 branch from 5539f55 to a35dcbb Compare June 2, 2021 09:15

dzenanz reviewed Jun 2, 2021

View reviewed changes

Comment thread CMake/itkCompilerChecks.cmake Outdated

N-Dekker force-pushed the CXX_STANDARD-from-11-to-14 branch from a35dcbb to 40a795f Compare June 2, 2021 14:42

dzenanz approved these changes Jun 2, 2021

View reviewed changes

tbaudier mentioned this pull request Jun 4, 2021

Compiling with master ITK/RTK and C++14 OpenGATE/Gate#443

Closed

N-Dekker added a commit to N-Dekker/ITKSoftwareGuide that referenced this pull request Jun 8, 2021

ENH: Update compiler versions for C++14

80b8f89

Following pull request InsightSoftwareConsortium/ITK#2563 "ENH: Upgrade ITK from C++11 to C++14" Suggested by Jon Haitz Legarreta Gorroño

N-Dekker mentioned this pull request Aug 26, 2021

Upgrade elastix from C++11 to C++14 SuperElastix/elastix#513

Merged

N-Dekker mentioned this pull request Mar 24, 2022

STYLE: Remove CMake checks on old MSVC versions (before version 1910) #3335

Merged

N-Dekker mentioned this pull request Mar 26, 2022

Remove obsolete CMake code for old GCC and Clang compilers #3340

Merged

N-Dekker mentioned this pull request Nov 14, 2022

STYLE: Remove obsolete __GNUC__ macro checks for GCC version 4 #3738

Merged

hjmjohnson pushed a commit that referenced this pull request Nov 19, 2022

STYLE: Remove obsolete __GNUC__ macro checks for GCC version 4

ce57f30

GCC 4 support was dropped with pull request #2563 commit 4e812d6 "COMP: Require compiler versions that support C++14", June 3, 2021

N-Dekker mentioned this pull request Mar 8, 2023

COMP: Fix uninitialized memory Valgrind defects #3933

Merged

2 tasks

N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Mar 17, 2023

ENH: Upgrade ITK from C++14 to C++17

6058407

Follow-up to pull request InsightSoftwareConsortium#2563 commit daec0fd "ENH: Upgrade ITK from C++11 to C++14"

N-Dekker mentioned this pull request Mar 17, 2023

ENH: Upgrade ITK from C++14 to C++17 #3969

Merged

N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Mar 18, 2023

ENH: Upgrade ITK from C++14 to C++17

2c6c613

Follow-up to pull request InsightSoftwareConsortium#2563 commit daec0fd "ENH: Upgrade ITK from C++11 to C++14"

N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Mar 18, 2023

ENH: Upgrade ITK from C++14 to C++17

c4faeab

Follow-up to pull request InsightSoftwareConsortium#2563 commit daec0fd "ENH: Upgrade ITK from C++11 to C++14"

N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Mar 22, 2023

ENH: Upgrade ITK from C++14 to C++17

6b6ddf5

Follow-up to pull request InsightSoftwareConsortium#2563 commit daec0fd "ENH: Upgrade ITK from C++11 to C++14"

dzenanz pushed a commit that referenced this pull request Mar 30, 2023

ENH: Upgrade ITK from C++14 to C++17

513507e

Follow-up to pull request #2563 commit daec0fd "ENH: Upgrade ITK from C++11 to C++14"

devbanu mentioned this pull request Jan 23, 2025

Request: Add build compiling with C++20 to GitHub actions. #3097

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ENH: Upgrade ITK from C++11 to C++14#2563

ENH: Upgrade ITK from C++11 to C++14#2563
dzenanz merged 3 commits intoInsightSoftwareConsortium:masterfrom
N-Dekker:CXX_STANDARD-from-11-to-14

N-Dekker commented May 31, 2021 •

edited

Loading

Uh oh!

dzenanz left a comment

Uh oh!

jhlegarreta commented Jun 1, 2021 •

edited

Loading

Uh oh!

dzenanz left a comment

Uh oh!

Uh oh!

jhlegarreta left a comment

Uh oh!

N-Dekker commented Jun 1, 2021

Uh oh!

dzenanz commented Jun 1, 2021

Uh oh!

N-Dekker Jun 1, 2021

Uh oh!

thewtex Jun 2, 2021

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

		# if defined(__clang__) && (__cplusplus < 201402L)
		# error "Apple LLVM < 5.1 (clang < 3.4) is not supported under ITKv5.3"

	if(CMAKE_CXX_EXTENSIONS)
	set(_castxml_cc_flags "${_castxml_cc_flags} ${CMAKE_CXX11_EXTENSION_COMPILE_OPTION}")
	else()
	set(_castxml_cc_flags "${_castxml_cc_flags} ${CMAKE_CXX11_STANDARD_COMPILE_OPTION}")
	endif()

Uh oh!

Conversation

N-Dekker commented May 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dzenanz left a comment

Choose a reason for hiding this comment

Uh oh!

jhlegarreta commented Jun 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dzenanz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jhlegarreta left a comment

Choose a reason for hiding this comment

Uh oh!

N-Dekker commented Jun 1, 2021

Uh oh!

dzenanz commented Jun 1, 2021

Uh oh!

N-Dekker Jun 1, 2021

Choose a reason for hiding this comment

Uh oh!

thewtex Jun 2, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

N-Dekker commented May 31, 2021 •

edited

Loading

jhlegarreta commented Jun 1, 2021 •

edited

Loading