STYLE: Remove obsolete __GNUC__ macro checks for GCC version 4#3738
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Nov 19, 2022
Merged
Conversation
GCC 4 support was dropped with pull request InsightSoftwareConsortium#2563 commit 4e812d6 "COMP: Require compiler versions that support C++14", June 3, 2021
github-actions
bot
added
area:Core
thewtex
reviewed
Nov 14, 2022
dzenanz
approved these changes
Nov 14, 2022
hjmjohnson
approved these changes
Nov 15, 2022
Member
|
/azp macOS |
Member
|
/azp run ITK.macOS |
Contributor
Author
|
@hjmjohnson Thanks for merging, Hans, I think the commit is fine as well, but wasn't it supposed to wait until after v5.3.0? Anyway, I don't expect any problem with this commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 4 support was dropped with pull request #2563 commit 4e812d6
"COMP: Require compiler versions that support C++14", June 3, 2021