COMP: Applied gtest PR 4025 to fix build with old clang

[seanm]

From: google/googletest#4025

[seanm]

@dzenanz

[kwrobot-v1]

Errors:

• Failed to fetch from the repository: host error: no result after exponential backoff.
• Failed to reserve ref bca75a0 for the merge request: invalid git ref: 'no such commit'.
• Failed to run the checks: mr utilities error: failed to list commits of bca75a08e2e17c4a01941bbdd7ff4789ef45219b for https://github.com/InsightSoftwareConsortium/ITK/pull/3978: fatal: bad object bca75a08e2e17c4a01941bbdd7ff4789ef45219b .

[kwrobot-v1]

Errors:

• Failed to fetch from the repository: host error: no result after exponential backoff.
• Failed to reserve ref bca75a0 for the merge request: invalid git ref: 'no such commit'.
• Failed to run the checks: mr utilities error: failed to list commits of bca75a08e2e17c4a01941bbdd7ff4789ef45219b for https://github.com/InsightSoftwareConsortium/ITK/pull/3978: fatal: bad object bca75a08e2e17c4a01941bbdd7ff4789ef45219b .

[kwrobot-v1]

Errors:

• Failed to fetch from the repository: host error: no result after exponential backoff.
• Failed to reserve ref bca75a0 for the merge request: invalid git ref: 'no such commit'.
• Failed to run the checks: mr utilities error: failed to list commits of bca75a08e2e17c4a01941bbdd7ff4789ef45219b for https://github.com/InsightSoftwareConsortium/ITK/pull/3978: fatal: bad object bca75a08e2e17c4a01941bbdd7ff4789ef45219b .

[kwrobot-v1]

Errors:

• Failed to fetch from the repository: host error: no result after exponential backoff.
• Failed to reserve ref bca75a0 for the merge request: invalid git ref: 'no such commit'.
• Failed to run the checks: mr utilities error: failed to list commits of bca75a08e2e17c4a01941bbdd7ff4789ef45219b for https://github.com/InsightSoftwareConsortium/ITK/pull/3978: fatal: bad object bca75a08e2e17c4a01941bbdd7ff4789ef45219b .

[N-Dekker]

Thanks @seanm but can't we drop the support for such old clang versions anyway?

I'm asking especially because of:

• pull request ENH: Upgrade ITK from C++14 to C++17 #3969

which proposes to require at least LLVM Clang 5 or Apple Clang 10.0.0 (from Xcode 10.0).

If I understand correctly, gtest PR google/googletest#4025 is only relevant for Clang < 3.8, right?

BTW, it looks like gtest has fixed the issue in a different way: google/googletest@a9b2f04 Is that approach also OK to you? It is included with GoogleTest release https://github.com/google/googletest/releases/tag/v1.13.0

[dzenanz]

Would updated GTest solve this issue for you?

[hjmjohnson]

Do: check

[dzenanz]

#3979 was merged. Does that fix the problem for you? If not, please update this PR as it now has merge conflicts.

[hjmjohnson]

I do think this is superceeded by #3979 and can be closed. @seanm Thanks for poking this. @dzenanz Thanks for updating google test.

[seanm]

#3979 was merged. Does that fix the problem for you?

We will see on cdash tomorrow...

[dzenanz]

If am reading the dashboard correctly, GTest compile failure is now gone.

[seanm]

If am reading the dashboard correctly, GTest compile failure is now gone.

Only because it's much worse, it doesn't build at all:

https://open.cdash.org/build/8590216/configure

CMake Error at CMake/itkCompilerChecks.cmake:16 (message):
  Apple Clang 10.0.0 or later is required.

[dzenanz]

That is due to merging the PR which bumps required C++ version to 17 (from C++14). Maybe it is time to retire those builds?