Skip to content

ENH: Use latest GTest#3979

Merged
dzenanz merged 3 commits intoInsightSoftwareConsortium:masterfrom
dzenanz:updateGTest
Mar 30, 2023
Merged

ENH: Use latest GTest#3979
dzenanz merged 3 commits intoInsightSoftwareConsortium:masterfrom
dzenanz:updateGTest

Conversation

@dzenanz
Copy link
Copy Markdown
Member

@dzenanz dzenanz commented Mar 29, 2023

PR Checklist

@dzenanz dzenanz mentioned this pull request Mar 29, 2023
Closed
@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Enhancement Improvement of existing methods or implementation type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:ThirdParty Issues affecting the ThirdParty module labels Mar 29, 2023
@kwrobot-v1
Copy link
Copy Markdown

kwrobot-v1 bot commented Mar 29, 2023

Errors:

  • Failed to fetch from the repository: host error: no result after exponential backoff.
  • Failed to reserve ref 2e36b05 for the merge request: invalid git ref: 'no such commit'.
  • Failed to run the checks: mr utilities error: failed to list commits of 2e36b055130752b858c15cf43e14c227c9edfb17 for https://github.com/InsightSoftwareConsortium/ITK/pull/3979: fatal: bad object 2e36b055130752b858c15cf43e14c227c9edfb17 .

@dzenanz
Copy link
Copy Markdown
Member Author

dzenanz commented Mar 29, 2023

@bradking ghostflow never reports, and kwrobot makes repeated comments with errors on PRs. It started happening a few days ago, I believe.

@bradking
Copy link
Copy Markdown
Member

bradking commented Mar 29, 2023

It's more fallout from the GitHub host key change. It should be fixed now.

@hjmjohnson
Copy link
Copy Markdown
Member

hjmjohnson commented Mar 29, 2023

Do: check

@dzenanz dzenanz marked this pull request as ready for review March 30, 2023 13:03
@dzenanz dzenanz requested review from N-Dekker, blowekamp and seanm March 30, 2023 13:03
blowekamp
blowekamp approved these changes Mar 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@blowekamp blowekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping it updated.

N-Dekker
N-Dekker reviewed Mar 30, 2023
View reviewed changes
Comment thread Modules/ThirdParty/GoogleTest/UpdateFromUpstream.sh Outdated
@N-Dekker
Copy link
Copy Markdown
Contributor

N-Dekker commented Mar 30, 2023

Please consider squashing the three commits together, to one. 😃

@dzenanz
Copy link
Copy Markdown
Member Author

dzenanz commented Mar 30, 2023

One commit is the update in the separate GTest root tree, one is a merge commit, and one is a regular commit. We cannot squash them without seriously shooting ourselves in the foot on the versioning front.

@N-Dekker
Copy link
Copy Markdown
Contributor

N-Dekker commented Mar 30, 2023

One commit is the update in the separate GTest root tree, one is a merge commit, and one is a regular commit. We cannot squash them without seriously shooting ourselves in the foot on the versioning front.

OK, thanks for your explanation 👍

dzenanz and others added 3 commits March 30, 2023 10:01
@dzenanz
ENH: Use latest stable GTest v1.13.0
5687500
@dzenanz
GoogleTest 2023-01-17 (b796f7d4)
1a5c2de 
Code extracted from:

    https://github.com/google/googletest.git

at commit b796f7d44681514f58a683a3a71ff17c94edb0c1 (v1.13.0).
@dzenanz
Merge branch 'upstream-GoogleTest'
b51acd3 
# By GoogleTest Upstream
* upstream-GoogleTest:
  GoogleTest 2023-01-17 (b796f7d4)
N-Dekker
N-Dekker approved these changes Mar 30, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@N-Dekker N-Dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dzenanz dzenanz merged commit c642a68 into InsightSoftwareConsortium:master Mar 30, 2023
@dzenanz dzenanz deleted the updateGTest branch March 30, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blowekamp blowekamp blowekamp approved these changes

@N-Dekker N-Dekker N-Dekker approved these changes

@seanm seanm Awaiting requested review from seanm

Assignees

No one assigned

Labels

area:ThirdParty Issues affecting the ThirdParty module type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dzenanz @bradking @hjmjohnson @N-Dekker @blowekamp