STYLE: Replace Fill(0.) and Fill(0u) with {} initializer for local variables in tests#4884
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom Oct 18, 2024
Conversation
github-actions
bot
added
type:Testing
Replaced `Fill(0.)`, `Fill(0.0)`, `Fill(0.0f)`, and `Fill(0u)` calls with `{}`
initializers.
Follow-up to pull request InsightSoftwareConsortium#4881
commit 569a8b6
"STYLE: Replace Fill(0) with {} initializer for local variables in tests"
N-Dekker
force-pushed
the
Replace-Fill-0-0
branch
from
ece8a10 to
fe83d68
Compare
dzenanz
approved these changes
Oct 18, 2024
Member
|
@N-Dekker Not sure if the dynamic analysis defects are a consequence of this PR, but a quick search of the commit that last modified the files points to this commit. Dynamic analysis on 2024-10-18: |
Contributor
Author
This one specifically reports a test failure of Update: I see now, there is an irregularity in the default-constructor of QuadEdgeMeshPoint that caused those regression failures! Thanks very much, @jhlegarreta ! 🎉 I'll prepare a PR! |
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Oct 21, 2024
Defaulted the default-constructor of `QuadEdgeMeshPoint`, and added an
initializer to its data member m_Edge, to ensure that an instance of this type
can be properly initialized by an empty initializer list, `{}`.
Aims to fix the dynamic analysis defects reported by Jon Haitz Legarreta Gorroño
at InsightSoftwareConsortium#4884 (comment)
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Oct 22, 2024
Replaced code of the form
T var;
var.Fill(x);
with `auto var = itk::MakeFilled<T>(x);`
Following C++ Core Guidelines, Oct 3, 2024, "Always initialize an object",
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-always
Using Notepad++, Replace in Files, doing:
Find what: ^( [ ]+)([^ ].*)[ ]+(\w+);[\r\n]+\1\3\.Fill\(
Replace with: $1auto $3 = itk::MakeFilled<$2>\(
Filters: itk*Test*.cxx
[v] Match case
(*) Regular expression
Follow-up to
- pull request InsightSoftwareConsortium#4881
- pull request InsightSoftwareConsortium#4884
- pull request InsightSoftwareConsortium#4887
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Oct 24, 2024
Replaced code of the form
T var;
var.Fill(x);
with `auto var = itk::MakeFilled<T>(x);`
Following C++ Core Guidelines, Oct 3, 2024, "Always initialize an object",
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-always
Using Notepad++, Replace in Files, doing:
Find what: ^( [ ]+)([^ ].*)[ ]+(\w+);[\r\n]+\1\3\.Fill\(
Replace with: $1auto $3 = itk::MakeFilled<$2>\(
Filters: itk*Test*.cxx
[v] Match case
(*) Regular expression
Follow-up to
- pull request InsightSoftwareConsortium#4881
- pull request InsightSoftwareConsortium#4884
- pull request InsightSoftwareConsortium#4887
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Oct 25, 2024
Replaced code of the form
T var;
var.Fill(x);
with `auto var = itk::MakeFilled<T>(x);`
Following C++ Core Guidelines, Oct 3, 2024, "Always initialize an object",
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-always
Using Notepad++, Replace in Files, doing:
Find what: ^( [ ]+)([^ ].*)[ ]+(\w+);[\r\n]+\1\3\.Fill\(
Replace with: $1auto $3 = itk::MakeFilled<$2>\(
Filters: itk*Test*.cxx
[v] Match case
(*) Regular expression
Follow-up to
- pull request InsightSoftwareConsortium#4881
- pull request InsightSoftwareConsortium#4884
- pull request InsightSoftwareConsortium#4887
thewtex
pushed a commit
that referenced
this pull request
Dec 12, 2024
Defaulted the default-constructor of `QuadEdgeMeshPoint`, and added an
initializer to its data member m_Edge, to ensure that an instance of this type
can be properly initialized by an empty initializer list, `{}`.
Aims to fix the dynamic analysis defects reported by Jon Haitz Legarreta Gorroño
at #4884 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
Fill(0.),Fill(0.0),Fill(0.0f), andFill(0u)calls with{}initializers.Fill(0)with{}initializer for local variables in tests #4881