Skip to content

BUG: QuadEdgeMeshPoint should be properly initialized by {}#4890

Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:QuadEdgeMeshPoint-default-constructor
Oct 22, 2024
Merged

BUG: QuadEdgeMeshPoint should be properly initialized by {}#4890
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:QuadEdgeMeshPoint-default-constructor

Conversation

@N-Dekker
Copy link
Copy Markdown
Contributor

Defaulted the default-constructor of QuadEdgeMeshPoint, and added an initializer to its data member m_Edge, to ensure that an instance of this type can be properly initialized by an empty initializer list, {}.

Aims to fix the dynamic analysis defects reported by Jon Haitz Legarreta Gorroño (@jhlegarreta) at #4884 (comment)

Defaulted the default-constructor of `QuadEdgeMeshPoint`, and added an
initializer to its data member m_Edge, to ensure that an instance of this type
can be properly initialized by an empty initializer list, `{}`.

Aims to fix the dynamic analysis defects reported by Jon Haitz Legarreta Gorroño
at InsightSoftwareConsortium#4884 (comment)
@github-actions github-actions bot added type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances area:Core Issues affecting the Core module labels Oct 21, 2024
@N-Dekker N-Dekker marked this pull request as ready for review October 21, 2024 19:05
Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up @N-Dekker 🥇

@thewtex thewtex merged commit 54fd2b4 into InsightSoftwareConsortium:master Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Core Issues affecting the Core module type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants