STYLE: Add constexpr to variables initialized by MakeFilled#4930
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Nov 5, 2024
Conversation
Suggests evaluating its value at compile-time, rather than at runtime.
Found by regular expressions:
^( [ ]+)(auto \w+[ ]+= MakeFilled<.+>\(-?\d+\);)
^( [ ]+)(auto \w+[ ]+= MakeFilled<.+>\(\d.0\);)
^( [ ]+)(auto \w+[ ]+= MakeFilled<.+>\(false\);)
^( [ ]+)(auto \w+[ ]+= MakeFilled<.+>\(true\);)
Inspired by a comment by Hans Johnson at
InsightSoftwareConsortium#4924 (comment)
github-actions
bot
added
area:Core
dzenanz
approved these changes
Nov 4, 2024
N-Dekker
commented
Nov 4, 2024
|
|
||
| // Build and setup the neighborhood iterator | ||
| auto radius = MakeFilled<typename NeighborhoodIteratorType::RadiusType>(1); | ||
| constexpr auto radius = MakeFilled<typename NeighborhoodIteratorType::RadiusType>(1); |
Contributor
Author
There was a problem hiding this comment.
We could even declare those variables static constexpr, instead of just non-static constexpr. I don't know if it matters much, in these cases 🤷 Some people prefer to always declare local variables static constexpr if possible.
Contributor
Author
|
FYI This PR has excluded variables that could not be declared |
Contributor
Author
|
/azp run ITK.Linux |
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Nov 9, 2024
Found by the regular expression `^( [ ]+)(auto \w+[ ]+= .+::Filled\(\d+\);)`
Manually excluded cases that did not compile, in
itkLabelMapContourOverlayImageFilter.hxx
itkBSplineControlPointImageFilter.hxx
itkBSplineScatteredDataPointSetToImageFilter.hxx
itkTileImageFilter.hxx
itkFFTDiscreteGaussianImageFilter.hxx
itkSLICImageFilter.hxx
- Follow-up to pull request InsightSoftwareConsortium#4930
commit fd14482
"STYLE: Add constexpr to variables initialized by MakeFilled"
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Nov 9, 2024
Found by the regular expression `^( [ ]+)(auto \w+[ ]+= .+::Filled\(\d+\);)`
Manually excluded cases that did not compile, in
itkLabelMapContourOverlayImageFilter.hxx
itkBSplineControlPointImageFilter.hxx
itkBSplineScatteredDataPointSetToImageFilter.hxx
itkTileImageFilter.hxx
itkFFTDiscreteGaussianImageFilter.hxx
itkSLICImageFilter.hxx
- Follow-up to pull request InsightSoftwareConsortium#4930
commit fd14482
"STYLE: Add constexpr to variables initialized by MakeFilled"
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Nov 9, 2024
Using Notepad++, Replace in Files, doing:
Find what: ^( [ ]+)(auto \w+[ ]+= .+::Filled\(\d+\);)
Replace with: $1constexpr $2
Filters: itk*.* !+\test
Directory: D:\src\ITK\Modules
[v] Match case
(*) Regular expression
Manually excluded cases that did not compile, in
itkLabelMapContourOverlayImageFilter.hxx
itkBSplineControlPointImageFilter.hxx
itkBSplineScatteredDataPointSetToImageFilter.hxx
itkTileImageFilter.hxx
itkFFTDiscreteGaussianImageFilter.hxx
itkSLICImageFilter.hxx
- Follow-up to pull request InsightSoftwareConsortium#4930
commit fd14482
"STYLE: Add constexpr to variables initialized by MakeFilled"
hjmjohnson
pushed a commit
that referenced
this pull request
Nov 11, 2024
Using Notepad++, Replace in Files, doing:
Find what: ^( [ ]+)(auto \w+[ ]+= .+::Filled\(\d+\);)
Replace with: $1constexpr $2
Filters: itk*.* !+\test
Directory: D:\src\ITK\Modules
[v] Match case
(*) Regular expression
Manually excluded cases that did not compile, in
itkLabelMapContourOverlayImageFilter.hxx
itkBSplineControlPointImageFilter.hxx
itkBSplineScatteredDataPointSetToImageFilter.hxx
itkTileImageFilter.hxx
itkFFTDiscreteGaussianImageFilter.hxx
itkSLICImageFilter.hxx
- Follow-up to pull request #4930
commit fd14482
"STYLE: Add constexpr to variables initialized by MakeFilled"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggests evaluating its value at compile-time, rather than at runtime.
Found by regular expressions:
Inspired by a comment by Hans Johnson (@hjmjohnson) at
#4924 (comment)