Add constexpr to variables initialized by T::Filled(x)#4942
Merged
hjmjohnson merged 3 commits intoInsightSoftwareConsortium:masterfrom Nov 11, 2024
Conversation
Contributor
N-Dekker
commented
Nov 9, 2024
N-Dekker
commented
- Follow-up to pull request STYLE: Add constexpr to variables initialized by MakeFilled #4930
Using Notepad++, Replace in Files, doing:
Find what: ^( [ ]+)(auto \w+[ ]+= .+::Filled\(\d+\);)
Replace with: $1constexpr $2
Filters: itk*.* !+\test
Directory: D:\src\ITK\Modules
[v] Match case
(*) Regular expression
Manually excluded cases that did not compile, in
itkLabelMapContourOverlayImageFilter.hxx
itkBSplineControlPointImageFilter.hxx
itkBSplineScatteredDataPointSetToImageFilter.hxx
itkTileImageFilter.hxx
itkFFTDiscreteGaussianImageFilter.hxx
itkSLICImageFilter.hxx
- Follow-up to pull request InsightSoftwareConsortium#4930
commit fd14482
"STYLE: Add constexpr to variables initialized by MakeFilled"
`Size::Filled(VRadius)` can be evaluated at compile-time.
`SizeType::Filled(SplineOrder + 1)` can be evaluated at compile-time.
github-actions
bot
added
area:Core
dzenanz
approved these changes
Nov 10, 2024
hjmjohnson
approved these changes
Nov 11, 2024
hjmjohnson
approved these changes
Nov 11, 2024
N-Dekker
deleted the
Add-constexpr-to-variables-initialized-by-Filled
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.