Remove clean step when building module wheels on Linux#200
Conversation
| || exit 1 | ||
| # Copy generated headers into sources before cleaning | ||
| find _skbuild -type f -wholename "**/cmake-build/include/*" -print -exec cp {} include \; | ||
| ${PYBIN}/python setup.py clean |
There was a problem hiding this comment.
@LucasGandel thanks for the patch!
Can we just remove this line instead?
There was a problem hiding this comment.
@thewtex Thanks, I just edited the change. You are right, it's better to remove the clean step and let the module CI decide what it wants to pick from this build.
Gives access to the configured headers of the module. This is required when chaining module builds. The latest module to be built must know about all the headers of former modules.
LucasGandel
force-pushed
the
manylinux-copy-configured-headers
branch
from
d692766 to
c953dc0
Compare
LucasGandel
changed the title
|
Thanks a lot for the review! Should we release new ITKPythonBuilds for this change to be effective in modules CI? |
|
@LucasGandel thanks for the patch! Yes, a new |
Yes, we can update both if needed. |
5 participants
This is required when chaining module builds. The latest module to be built
must know about all the headers of former modules.
Our use case is that CudaCommon generates an export header that is then required when building RTK. I guess this does not happen for ITKUltrasound because all the modules it depends on are not generating export headers.
@dzenanz @thewtex Can you review this please?
@SimonRit FYI