Skip to content

manylinux: clean the build directory before building wheels#202

Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
LucasGandel:manylinux-clean-build
Sep 9, 2022
Merged

manylinux: clean the build directory before building wheels#202
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
LucasGandel:manylinux-clean-build

Conversation

@LucasGandel
Copy link
Copy Markdown
Collaborator

Commit #c953dc0 removed the clean step to allow accessing configured files when the script exists. However, when running two consecutive builds for different tarball specialization, the 1st build directory must be cleaned to make sure all libs are rebuilt for the right platform.

Commit #c953dc0 removed the clean step to allow accessing configured files
when the script exists. However, when running two consecutive builds for
different tarball specialization, the 1st build directory must be cleaned
to make sure all libs are rebuilt for the right platform.
@LucasGandel
Copy link
Copy Markdown
Collaborator Author

@thewtex the change introduced in #200 breaks the ability to build multiple wheels with different "tarball specialization". When building the second wheel, there are some targets that are wrongly rebuilt with the previous specialization (see here).

This PR fixes it by cleaning any previous build before building a new wheel. Can you please review?

cc: @SimonRit

@dzenanz dzenanz requested a review from thewtex September 9, 2022 12:39
Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LucasGandel LGTM, thanks!

We are looking at updating the macOS XCode version, also. So, I will produce a new version with this change, in 5.3rc4.post3.

@thewtex thewtex merged commit 4e657a7 into InsightSoftwareConsortium:master Sep 9, 2022
@LucasGandel
Copy link
Copy Markdown
Collaborator Author

We are looking at updating the macOS XCode version, also. So, I will produce a new version with this change, in 5.3rc4.post3.

Thanks a lot @thewtex!

@SimonRit
Copy link
Copy Markdown

Thanks a lot @thewtex . While waiting for 5.3rc4.post3, do you think it makes sense to restore the original linux asset for v5.3rc04.post2? My attempt at releasing RTK failed due to the faulty ITKPythonBuilds-linux.tar.zst , see here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants