Skip to content

[internal review, not for upstream yet] docs: state the anchored additivity invariant#25

Closed
ColinDKelley wants to merge 1 commit into
prom-18679/upstream-snapshotfrom
prom-18679/feature-flags-callout
Closed

[internal review, not for upstream yet] docs: state the anchored additivity invariant#25
ColinDKelley wants to merge 1 commit into
prom-18679/upstream-snapshotfrom
prom-18679/feature-flags-callout

Conversation

@ColinDKelley
Copy link
Copy Markdown

@ColinDKelley ColinDKelley commented May 13, 2026

Internal-review draft

This is the first of two upstream-bound PRs that follow up on prometheus/prometheus#18679. It is filed against Invoca/prometheus:prom-18679/upstream-snapshot (a pinned mirror of prometheus/prometheus@e793b2671) so the diff shows only the proposed upstream change. Do not push this branch upstream until we've reviewed.

The companion proposal-text amendment is here: Invoca/proposals#1.

What this changes

docs/feature_flags.md, inside the ### anchored subsection: appends a short callout that states the additive property of anchored-mode increase / rate / delta. The callout points at upstream issue prometheus#18679 for the precise statement and proposed tests.

Rendered preview: docs/feature_flags.md on this branch

Why

  • The proposal already lists "Improved composability across range boundaries" as a use case (proposal 0052, line 222), but neither the proposal nor the user-facing docs say what exactly "composable" means.
  • We've run yincrease / yrate / ydelta in production for ~3 years and the additive property is the reason it stays predictable and explainable under irregular scrapes, with no partition-boundary surprises. Putting it in writing here in feature-flag doc makes the guarantee discoverable.
  • Sets up the proposal-amendment PR to anchor on a one-line invariant rather than re-deriving it.

Review checklist

Once approved

  • Retarget base to prometheus/prometheus:main
  • Convert from draft to ready-for-review
  • Cross-reference from the upstream issue thread

Add a callout in the anchored section of feature_flags.md naming the
additive (composability) property of anchored-mode increase/rate/delta,
and link to prometheus#18679 for the precise statement and proposed invariant
tests.

Signed-off-by: Colin Kelley <colin@invoca.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ColinDKelley ColinDKelley force-pushed the prom-18679/feature-flags-callout branch from cf3d7e1 to 585a5b7 Compare May 13, 2026 23:52
@ColinDKelley
Copy link
Copy Markdown
Author

Internal review complete. Squashed + DCO-signed and filed upstream as draft: prometheus#18690. Closing this internal PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant