[internal review, not for upstream yet] docs: state the anchored additivity invariant#25
Closed
ColinDKelley wants to merge 1 commit into
Closed
Conversation
5 tasks
Add a callout in the anchored section of feature_flags.md naming the additive (composability) property of anchored-mode increase/rate/delta, and link to prometheus#18679 for the precise statement and proposed invariant tests. Signed-off-by: Colin Kelley <colin@invoca.com> Co-authored-by: Cursor <cursoragent@cursor.com>
cf3d7e1 to
585a5b7
Compare
Author
|
Internal review complete. Squashed + DCO-signed and filed upstream as draft: prometheus#18690. Closing this internal PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal-review draft
This is the first of two upstream-bound PRs that follow up on prometheus/prometheus#18679. It is filed against
Invoca/prometheus:prom-18679/upstream-snapshot(a pinned mirror ofprometheus/prometheus@e793b2671) so the diff shows only the proposed upstream change. Do not push this branch upstream until we've reviewed.The companion proposal-text amendment is here: Invoca/proposals#1.
What this changes
docs/feature_flags.md, inside the### anchoredsubsection: appends a short callout that states the additive property ofanchored-modeincrease/rate/delta. The callout points at upstream issue prometheus#18679 for the precise statement and proposed tests.Rendered preview: docs/feature_flags.md on this branch
Why
yincrease/yrate/ydeltain production for ~3 years and the additive property is the reason it stays predictable and explainable under irregular scrapes, with no partition-boundary surprises. Putting it in writing here in feature-flag doc makes the guarantee discoverable.Review checklist
T₀ T₁ T₂,r₁ r₂)anchoredblockOnce approved
prometheus/prometheus:main