[internal review, not for upstream yet] proposal-0052: name the additive property of anchored#1
Draft
ColinDKelley wants to merge 7 commits into
Draft
[internal review, not for upstream yet] proposal-0052: name the additive property of anchored#1ColinDKelley wants to merge 7 commits into
ColinDKelley wants to merge 7 commits into
Conversation
Add a "Composability as the additive property" sub-block to the `anchored` section of proposal 0052. The "Improved composability across range boundaries" use case (line 222) is in fact the well-defined additive property; this amendment writes that down so future readers can find it, and shows that the partial-dataset diagram (line 235) is the property in action. Links to prometheus/prometheus#18679 for the proof sketch and proposed invariant tests. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ved' Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal-review draft
This is the second of two upstream-bound PRs that follow up on prometheus/prometheus#18679. The companion docs callout is at Invoca/prometheus#25.
Base is
Invoca/proposals:main, which was just forked fromprometheus/proposals@0c03113and has zero drift. Do not push upstream until we've reviewed.What this changes
proposals/0052-extended-range-selectors-semantics.md, inside the### How This Proposal Works→#### anchoredblock: adds a new "Composability as the additive property" sub-section immediately after the existing "Use cases" bullets. The sub-section:feature_flags.mdcallout.Rendered preview: proposals/0052-extended-range-selectors-semantics.md on this branch
Why amend the proposal (not just the docs)?
anchoredis going to be the standard answer for "give me drop-inincrease/ratethat I can trust under irregular scrapes," the spec should name that guarantee — the same way the existing pitfalls section in the proposal names what was wrong with the legacyrate.Review checklist
Once approved
prometheus/proposals:main