release/1.7.0: revert uppercase PACKAGE_ROOT env vars

[climbfuji]

Summary

Update submodule pointer for the changes described in JCSDA/spack#421 and remove the previously added jedi_cmake_ROOT env vars in configs/common/modules_*.yaml.

This is for the release branch. After this is merged, we will need to retag the spack submodule, update spack-stack (remove the extra JEDI_CMAKE_ROOT env settings in configs/common/modules.*yaml), tag, go back to all supported platforms, check out the final tagged code, and rerun the spack module ??? refresh && spack stack setup-meta-modules commands.

List of platforms:

• Hercules (@RatkoVasic-NOAA)
• Orion (@RatkoVasic-NOAA)
• Discover (@climbfuji)
• Casper (@climbfuji)
• Derecho (@RatkoVasic-NOAA)
• Acorn (@AlexanderRichert-NOAA)
• Gaea C5 (@RatkoVasic-NOAA)
• Hera (@AlexanderRichert-NOAA)
• Jet (@AlexanderRichert-NOAA)
• Narwhal (@climbfuji)
• Nautilus (@climbfuji)
• S4 (@climbfuji)
• AWS AMI RH 8 (@climbfuji)
• AWS CI cluster (existing, c6i; @climbfuji)
• AWS ParallelCluster (decommissioned - if resurrected, then @climbfuji)
• NOAA ParallelWorks EPIC (@natalie-perlin)
• NOAA ParallelWorks JCSDA (@climbfuji)

Testing

• CI

Applications affected

All = none (because our applications still expect the lowercase/case-preserving version)

Systems affected

All

Dependencies

• Use case-preserving packageName_ROOT env variables in auto-generated modules spack#421

Issue(s) addressed

Resolves #1066

Checklist

• This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
• These changes have been tested on the affected systems and applications.
• All dependency PRs/issues have been resolved and this PR can be merged.

[AlexanderRichert-NOAA]

It sounds like it should work to run git submodule update --remote spack then rebuild the modules?

[climbfuji]

It sounds like it should work to run git submodule update --remote spack then rebuild the modules?

Please try, yes.

I'll do the following after this is merged and spack-stack tagged (so that I know for sure I have the final tag on the system):

git remote update
git checkout origin/1.7.0
git submodule update spack
# do the things needed to activate the environment
spack module [tcl|lmod] refresh
spack-stack setup-meta-modules # strictly speaking only needed for tcl, but doesn't hurt

[climbfuji]

@AlexanderRichert-NOAA I think we can merge this first, then tag and complete the list above. I tested it on my macOS and it works as expected.

[natalie-perlin]

@climbfuji -
Does the environment ue-intel need to be activated to run these updates?

[natalie-perlin]

... appears to be...
git checkout release/1.7.0

[climbfuji]

... appears to be... git checkout release/1.7.0

#1068 (comment)

Sorry, not being sufficiently clear - I mean that we run full sequence of commands, except there is no "origin/1.7.0" branch, and it's "release/1.7.0"

[climbfuji]

... appears to be... git checkout release/1.7.0

#1068 (comment)

Sorry, not being sufficiently clear - I mean that we run full sequence of commands, except there is no "origin/1.7.0" branch, and it's "release/1.7.0"

git remote update ? that will give you 1.7.0

[climbfuji]

I've done my share except Derecho and Casper, which are currently offline due to network issues. I'll check back tonight and complete my assignments

[AlexanderRichert-NOAA]

@natalie-perlin yes, the environment needs to be activated so Spack knows which environment to do the module updates for.

[natalie-perlin]

... done with NOAA Parallel Works CSP

[climbfuji]

... done with NOAA Parallel Works CSP

Thank you @natalie-perlin !

[climbfuji]

@AlexanderRichert-NOAA Only Acorn missing I think