Use case-preserving packageName_ROOT env variables in auto-generated modules#421
Merged
climbfuji merged 2 commits intoJCSDA:release/1.7.0from Apr 10, 2024
Conversation
…modules instead of all uppercase PACKAGENAME_ROOT
climbfuji
added
INFRA
climbfuji
requested review from
AlexanderRichert-NOAA,
RatkoVasic-NOAA and
natalie-perlin
Collaborator
Author
|
@AlexanderRichert-NOAA I am going to plow ahead here. I just discussed with the spack developers and we'll look into a more general solution for spack after their next release that will allow users to state if they want lowercase, case-preserving (which for the case of spack packages is the same as lowercase), and uppercase. We'll get this update in from spack mainline once it is ready, but for now we can revert to what we had beforehand. Please follow spack#43569 for updates on spack develop. |
Collaborator
|
Yep sounds good to me, I agree it's not worth the pain right now :) |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use case-preserving packageName_ROOT env variables in auto-generated modules instead of all uppercase PACKAGENAME_ROOT.
See JCSDA/spack-stack#1068 for a list of systems that need to get updated for spack-stack-1.7.0.
Issue(s) addressed
Resolves JCSDA/spack-stack#1066
Related spack develop issue: spack#43569
Dependencies
n/a
Impact
Fixes cmake warnings and build errors.
Checklist