code_warntype docs: more neutral reference to @code_warntype#51361
Merged
KristofferC merged 6 commits intoJuliaLang:masterfrom Feb 8, 2024
Merged
code_warntype docs: more neutral reference to @code_warntype#51361KristofferC merged 6 commits intoJuliaLang:masterfrom
KristofferC merged 6 commits intoJuliaLang:masterfrom
Conversation
Contributor
|
I don’t think the old reference should be completely removed as when accessing it from the docs, it links to https://docs.julialang.org/en/v1/manual/performance-tips/#man-code-warntype which actually does have more information. Maybe rewording it to make it clear that it’s linking to a section of the Performance Tips page in the manual would be more helpful. |
Contributor
|
Maybe something like
|
Member
|
Yes, (as was more or less already sais) the issue is that from the terminals p.o.v it looks like this is a link to the |
Contributor
Author
|
I updated it as suggested. |
Contributor
|
You want to modify line 73 without removing line 75. |
Contributor
Author
|
My bad. Another attempt is in. |
KristofferC
reviewed
Sep 20, 2023
fingolfin
added
merge me
KristofferC
pushed a commit
that referenced
this pull request
Feb 26, 2024
KristofferC
pushed a commit
that referenced
this pull request
Feb 26, 2024
KristofferC
added a commit
that referenced
this pull request
Feb 27, 2024
Backported PRs: - [x] #53205 <!-- Profile: add notes to `print()` docs --> - [x] #53170 <!-- Remove outdated discussion about externally changing module bindings --> - [x] #53228 <!-- SubArray: avoid invalid elimination of singleton indices --> - [x] #51361 <!-- code_warntype docs: more neutral reference to @code_warntype --> - [x] #50480 <!-- Document --heap-size-hint in Command-line Interface --> - [x] #53301 <!-- Fix typo in `Sys.total_memory` docstring. --> - [x] #53354 <!-- fix code coverage bug in tail position and `else` --> - [x] #53388 <!-- Fix documentation: thread pool of main thread --> - [x] #53429 <!-- Subtype: skip slow-path in `local_∀_∃_subtype` if inputs contain no ∃ typevar. --> - [x] #53437 <!-- Add debug variant of loader_trampolines.o --> Need manual backport: - [ ] #52505 <!-- fix alignment of emit_unbox_store copy --> - [ ] #53373 <!-- fix sysimage-native-code=no option with pkgimages --> - [ ] #53439 <!-- staticdata: fix assert from partially disabled native code --> Contains multiple commits, manual intervention needed: - [ ] #52913 <!-- Added docstring for Artifacts.jl --> - [ ] #53218 <!-- Fix interpreter_exec.jl test --> Non-merged PRs with backport label: - [ ] #53424 <!-- yet more atomics & cache-line fixes on work-stealing queue --> - [ ] #53125 <!-- coverage: count coverage where explicitly requested by inference only --> - [ ] #52694 <!-- Reinstate similar for AbstractQ for backward compatibility --> - [ ] #51479 <!-- prevent code loading from lookin in the versioned environment when building Julia -->
KristofferC
removed
the
backport 1.10
Drvi
pushed a commit
to RelationalAI/julia
that referenced
this pull request
Jun 7, 2024
…ng#51361) fix JuliaLang#51358 --------- Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com> Co-authored-by: Max Horn <max@quendi.de> (cherry picked from commit 5cb5cd8)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #51358