Fixing Confidence Pair Alignment Issues#1226
Merged
Merged
Conversation
BryonLewis
force-pushed
the
client/fix-1221
branch
from
29977e5 to
625e898
Compare
marySalvi
approved these changes
Apr 27, 2022
Collaborator
marySalvi
left a comment
marySalvi
left a comment
There was a problem hiding this comment.
LGTM Particularly like the ternary logic for the alignment, clever.
Manually tested each fix and ran integration testing too.
marySalvi
pushed a commit
that referenced
this pull request
May 9, 2022
* css change * fix import and training order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1221
Dataset that demonstrates the issue: https://viame.kitware.com/#/viewer/62584c41f3a0a95bd8eb1f2c
Click the first fish on the left and go to the detailed panel.
Fixing the column sizes allows for proper wrapping of the type text:
The one column has a ternary operator to adjust the column width slightly. Without this a single already set confidence value may look weird:
Without ternary operator:
(Note additional white space)
With ternary operator:
fixes #999
Adds a sorting to the training configuration names after they are updated so they are returned in the proper order for the client. The desktop version already did proper sorting of the training configuration names.
fixes #1219
Modified the input filename paths so that they update if the user happens to type or delete values in there instead of using the default filename loaded.