Skip to content

docs: ADR-008 — personality/assessment frameworks as anchors (the Utility Gate)#676

Merged
rdmueller merged 1 commit into
LLM-Coding:mainfrom
raifdmueller:docs/adr-008-personality-anchors
Jul 6, 2026
Merged

docs: ADR-008 — personality/assessment frameworks as anchors (the Utility Gate)#676
rdmueller merged 1 commit into
LLM-Coding:mainfrom
raifdmueller:docs/adr-008-personality-anchors

Conversation

@raifdmueller

@raifdmueller raifdmueller commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Records the decision requested in the review of the personality-model proposals: does the catalog admit personality/assessment frameworks as anchors, and by what rule?

Decision

A topic-neutral Utility Gate. No subject area is banned or blessed. A personality/assessment framework is admitted as an anchor iff it (1) passes the four Quality Criteria, (2) passes the existing Viability Test (naming it demonstrably changes the LLM's output structure — not mere recognition), and (3) carries a Criticism/Current Status section. This makes the template's existing "without LLM utility" wording the general law, and removes the contradiction with the in-catalog MBTI anchor by subjecting MBTI to the same test.

Pugh: Utility Gate +63 vs. exclude-category −10 vs. liberal-admit −12 (baseline status-quo 0).

Consequences for the open proposals

Changed

  • New docs/specs/adrs/adr-008-personality-assessment-anchors.adoc (Nygard + Pugh, matching ADR-007).
  • CONTRIBUTING.adoc + docs/CONTRIBUTING.de.adoc — one sentence making the gate topic-neutral, citing ADR-008.
  • propose-anchor.yml — rejection bullet reworded from the MBTI example to the topic-neutral gate.
  • arc42 Chapter 9 ADR index — ADR-008 row; next-free-number note bumped to ADR-009.

Decision taken under delegation ("let's decide now and record as ADR"); amend the Status/ruling if you'd prefer a different option.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Dokumentation
    • Neue ADR-008 ergänzt die Entscheidungsgrundlage für „Personality & assessment frameworks“ als Anker („Utility Gate“) mit Status Accepted.
    • Beitragshinweise (EN/DE) und das Proposal-Template wurden aktualisiert: Ablehnung erfolgt themenneutral, wenn ein Begriff keinen nachweisbaren Output-Nutzen zeigt; „Recognition-only“ fällt durch.
    • Ergänzend wird eine == Criticism / == Current Status-Sektion für umstrittene Begriffe eingefordert.
    • Changelog und Architektur-Übersicht wurden um ADR-008 erweitert.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 61881cd1-d565-40d2-ae9c-cbcaf3023d77

📥 Commits

Reviewing files that changed from the base of the PR and between d1bbea4 and c0be728.

📒 Files selected for processing (6)
  • .github/ISSUE_TEMPLATE/propose-anchor.yml
  • CONTRIBUTING.adoc
  • docs/CONTRIBUTING.de.adoc
  • docs/arc42/chapters/09_architecture_decisions.adoc
  • docs/changelog.adoc
  • docs/specs/adrs/adr-008-personality-assessment-anchors.adoc
✅ Files skipped from review due to trivial changes (3)
  • .github/ISSUE_TEMPLATE/propose-anchor.yml
  • docs/arc42/chapters/09_architecture_decisions.adoc
  • docs/specs/adrs/adr-008-personality-assessment-anchors.adoc
🚧 Files skipped from review as they are similar to previous changes (3)
  • docs/CONTRIBUTING.de.adoc
  • CONTRIBUTING.adoc
  • docs/changelog.adoc

Walkthrough

Die PR ergänzt ADR-008 für ein themenneutrales Utility-Gate bei Personality-/Assessment-Frameworks als Semantic Anchors. Dazu werden das Issue-Template, die CONTRIBUTING-Dokumente (EN/DE), die ADR-Übersicht in arc42 und der Changelog an diese Regel angepasst.

Changes

ADR-008 Utility Gate

Layer / File(s) Summary
ADR-008 Dokument
docs/specs/adrs/adr-008-personality-assessment-anchors.adoc
Neuer ADR definiert die topic-neutrale Utility-Gate-Regel, Viability-Test-Anforderungen sowie Criticism/Current-Status-Pflicht, inkl. Pugh-Matrix für DISC, Big Five, HEXACO, WEIRD und MBTI.
Template und CONTRIBUTING Anpassungen
.github/ISSUE_TEMPLATE/propose-anchor.yml, CONTRIBUTING.adoc, docs/CONTRIBUTING.de.adoc
Rejection Criteria im Template ersetzt die bisherige Ablehnung durch eine Recognition-only-/Viability-Test-Regel; CONTRIBUTING (EN/DE) erhält den neuen Gate-Hinweis mit Verweis auf ADR-008.
ADR-Index und Changelog
docs/arc42/chapters/09_architecture_decisions.adoc, docs/changelog.adoc
Die arc42-Übersicht erhält ADR-008, die nächste freie ADR-Nummer wird auf ADR-009 korrigiert, und der Changelog dokumentiert die neue Utility-Gate-Regel.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • LLM-Coding/Semantic-Anchors#605: Behandelt dieselbe Dokumentationslinie zu verpflichtenden == Criticism/== Current Status-Abschnitten für Anker-Vorschläge.

Suggested reviewers: JensGrote

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Der Titel benennt ADR-008 und den Utility-Gate-Änderungsschwerpunkt der Änderungen präzise und passend.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/arc42/chapters/09_architecture_decisions.adoc`:
- Around line 47-50: The ADR-008 reference in the architecture decisions chapter
points to the wrong relative location and resolves to a non-existent path.
Update the link in the architecture decisions table entry that uses the ADR-008
label so it matches the other ADR references and points to the correct
../../specs/adrs/... target instead of ../specs/adrs/... .

In `@docs/CONTRIBUTING.de.adoc`:
- Around line 101-102: In the CONTRIBUTING.de.adoc text, fix the grammatical
gender of the phrase in the gate description by changing the referenced wording
from “Dieser Gate” to “Dieses Gate.” Update the sentence in the paragraph that
mentions the themeneutral gate and the Personality-/Assessment-Modelle (MBTI,
DISC, Big Five, HEXACO) so the surrounding meaning stays unchanged while using
the correct neuter form.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 68f84719-6d0b-4122-b4ed-71548284b840

📥 Commits

Reviewing files that changed from the base of the PR and between b604f01 and d1bbea4.

📒 Files selected for processing (6)
  • .github/ISSUE_TEMPLATE/propose-anchor.yml
  • CONTRIBUTING.adoc
  • docs/CONTRIBUTING.de.adoc
  • docs/arc42/chapters/09_architecture_decisions.adoc
  • docs/changelog.adoc
  • docs/specs/adrs/adr-008-personality-assessment-anchors.adoc

Comment thread docs/arc42/chapters/09_architecture_decisions.adoc Outdated
Comment thread docs/CONTRIBUTING.de.adoc Outdated
… Gate)

Resolve the MBTI-vs-template contradiction with a topic-neutral rule:
a framework is admitted iff it passes the existing Viability Test
(naming it changes output structure), never by topic. MBTI is subjected
to the same gate. Mirror the rule into CONTRIBUTING (EN+DE) and the
proposal template; register ADR-008 in the arc42 ch.9 index.

Governs LLM-Coding#671 (DISC), LLM-Coding#673 (Big Five/OCEAN), LLM-Coding#674 (HEXACO), LLM-Coding#675 (WEIRD).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@raifdmueller
raifdmueller force-pushed the docs/adr-008-personality-anchors branch from d1bbea4 to c0be728 Compare July 6, 2026 20:53
@raifdmueller

Copy link
Copy Markdown
Contributor Author

Rebased onto main (resolves the changelog conflict from #672) and addressed both CodeRabbit findings:

  • docs/arc42/chapters/09_architecture_decisions.adoc — ADR-008 link corrected to ../../specs/adrs/… (matches ADR-001–005; the ../ form resolved to a dead docs/arc42/specs/…). Note: the pre-existing ADR-006/007 rows still carry the same ../ bug — left out of scope here.
  • docs/CONTRIBUTING.de.adoc — grammar fix Dieser GateDieses Gate (neuter).

@rdmueller
rdmueller merged commit aa70c70 into LLM-Coding:main Jul 6, 2026
8 checks passed
@raifdmueller
raifdmueller deleted the docs/adr-008-personality-anchors branch July 6, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants