docs: ADR-008 — personality/assessment frameworks as anchors (the Utility Gate)#676
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughDie PR ergänzt ADR-008 für ein themenneutrales Utility-Gate bei Personality-/Assessment-Frameworks als Semantic Anchors. Dazu werden das Issue-Template, die CONTRIBUTING-Dokumente (EN/DE), die ADR-Übersicht in arc42 und der Changelog an diese Regel angepasst. ChangesADR-008 Utility Gate
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/arc42/chapters/09_architecture_decisions.adoc`:
- Around line 47-50: The ADR-008 reference in the architecture decisions chapter
points to the wrong relative location and resolves to a non-existent path.
Update the link in the architecture decisions table entry that uses the ADR-008
label so it matches the other ADR references and points to the correct
../../specs/adrs/... target instead of ../specs/adrs/... .
In `@docs/CONTRIBUTING.de.adoc`:
- Around line 101-102: In the CONTRIBUTING.de.adoc text, fix the grammatical
gender of the phrase in the gate description by changing the referenced wording
from “Dieser Gate” to “Dieses Gate.” Update the sentence in the paragraph that
mentions the themeneutral gate and the Personality-/Assessment-Modelle (MBTI,
DISC, Big Five, HEXACO) so the surrounding meaning stays unchanged while using
the correct neuter form.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 68f84719-6d0b-4122-b4ed-71548284b840
📒 Files selected for processing (6)
.github/ISSUE_TEMPLATE/propose-anchor.ymlCONTRIBUTING.adocdocs/CONTRIBUTING.de.adocdocs/arc42/chapters/09_architecture_decisions.adocdocs/changelog.adocdocs/specs/adrs/adr-008-personality-assessment-anchors.adoc
… Gate) Resolve the MBTI-vs-template contradiction with a topic-neutral rule: a framework is admitted iff it passes the existing Viability Test (naming it changes output structure), never by topic. MBTI is subjected to the same gate. Mirror the rule into CONTRIBUTING (EN+DE) and the proposal template; register ADR-008 in the arc42 ch.9 index. Governs LLM-Coding#671 (DISC), LLM-Coding#673 (Big Five/OCEAN), LLM-Coding#674 (HEXACO), LLM-Coding#675 (WEIRD). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
d1bbea4 to
c0be728
Compare
|
Rebased onto main (resolves the changelog conflict from #672) and addressed both CodeRabbit findings:
|
Records the decision requested in the review of the personality-model proposals: does the catalog admit personality/assessment frameworks as anchors, and by what rule?
Decision
A topic-neutral Utility Gate. No subject area is banned or blessed. A personality/assessment framework is admitted as an anchor iff it (1) passes the four Quality Criteria, (2) passes the existing Viability Test (naming it demonstrably changes the LLM's output structure — not mere recognition), and (3) carries a Criticism/Current Status section. This makes the template's existing "without LLM utility" wording the general law, and removes the contradiction with the in-catalog MBTI anchor by subjecting MBTI to the same test.
Pugh: Utility Gate +63 vs. exclude-category −10 vs. liberal-admit −12 (baseline status-quo 0).
Consequences for the open proposals
Changed
docs/specs/adrs/adr-008-personality-assessment-anchors.adoc(Nygard + Pugh, matching ADR-007).CONTRIBUTING.adoc+docs/CONTRIBUTING.de.adoc— one sentence making the gate topic-neutral, citing ADR-008.propose-anchor.yml— rejection bullet reworded from the MBTI example to the topic-neutral gate.Decision taken under delegation ("let's decide now and record as ADR"); amend the Status/ruling if you'd prefer a different option.
🤖 Generated with Claude Code
Summary by CodeRabbit
== Criticism/== Current Status-Sektion für umstrittene Begriffe eingefordert.