feat: add DISC anchor under ADR-008 (#671)#684
Conversation
DISC passes the Utility Gate like MBTI — naming it imposes the four- quadrant (D/I/S/C) frame — so it is admitted at tier 1 with an :advisory: flag and a fetch-verified Criticism section (pseudoscience; no predictive validity; Barnum effect; explainable as Big Five combinations). Marston (theory, 1928); instruments came later. Bilingual, cross-linked with MBTI/Big Five/HEXACO (MBTI :related: now includes disc-model). Completes the personality-model cluster under ADR-008. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughDiese PR fügt einen neuen semantischen Anchor für das „DISC-Modell (Marston)“ hinzu, ergänzt Verlinkungen in bestehenden Anchors, dokumentiert die Aufnahme im Changelog und erweitert zwei Katalogreferenzen. ChangesDISC-Modell Anchor Einführung
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/anchors/disc-model.adoc`:
- Around line 53-56: The Criticism section in disc-model.adoc relies on the
Wikipedia overview instead of primary sources, so update the DISC assessment
references to cite the underlying studies/authors directly. In the existing
Criticism bullets, replace or supplement the Wikipedia-attributed claims with
explicit citations for the validity/job-performance findings and the Big Five
interpretation, keeping the argument anchored to the referenced research rather
than the summary page.
In `@docs/anchors/disc-model.de.adoc`:
- Around line 53-61: Die Abschnittsüberschriften im deutschen Anchor-Dokument
sind noch englisch und sollten sprachlich konsistent übersetzt werden. Passe in
disc-model.de.adoc die Überschriften der Abschnitte mit den Symbolen `Criticism`
und `Current Status` auf `Kritik` und `Aktueller Status` an, damit die deutsche
Version vollständig lokalisiert ist. Achte darauf, die Struktur und den übrigen
Inhalt unverändert zu lassen.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 574aa467-32c8-4f8a-8e40-cd2af96d7eca
📒 Files selected for processing (7)
docs/anchors/disc-model.adocdocs/anchors/disc-model.de.adocdocs/anchors/myers-briggs-type-indicator.adocdocs/anchors/myers-briggs-type-indicator.de.adocdocs/changelog.adocplugins/semantic-anchors/skills/semantic-anchor-translator/references/catalog.mdskill/semantic-anchor-translator/references/catalog.md
| == *Criticism*: | ||
|
|
||
| * Via the https://en.wikipedia.org/wiki/DISC_assessment[DISC assessment overview] — classified as *pseudoscientific*: the scientific validity of DISC has not been demonstrated, and the assessments have shown *no ability to predict job performance* (a 2013 German study found reliability "largely" met but validity "not at all"). DISC data are better explained as combinations of the Big Five than as independent traits. | ||
| * Its apparent accuracy is partly the *Barnum effect* — people accept vague, broadly flattering descriptions as personally true. Marston's four categories ignore personality science after 1920. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Primärquellen direkt referenzieren.
Die Kritik-Sektion stützt sich derzeit nur auf den Wikipedia-Überblick; die Aussagen zu Validität und Big-Five-Bezug sollten im Anchor selbst auf die zugrunde liegenden Studien/Autoren zurückgeführt werden, damit die Attribuierung sauber bleibt.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/anchors/disc-model.adoc` around lines 53 - 56, The Criticism section in
disc-model.adoc relies on the Wikipedia overview instead of primary sources, so
update the DISC assessment references to cite the underlying studies/authors
directly. In the existing Criticism bullets, replace or supplement the
Wikipedia-attributed claims with explicit citations for the
validity/job-performance findings and the Big Five interpretation, keeping the
argument anchored to the referenced research rather than the summary page.
Source: Path instructions
- German section headings localized: Criticism -> Kritik, Current Status -> Aktueller Status (matches the existing DE convention, e.g. eisenhower-matrix.de); advisory reference updated to 'siehe Kritik'. - Criticism now names the attributed critic (Wendell Williams) alongside the fetch-verified DISC-assessment source, EN + DE. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Same fix as DISC, folded into this PR: the earlier merged personality anchors also had English == Criticism / == Current Status headings in their German files. Localize to == Kritik / == Aktueller Status (matching the DE convention), and fix the MBTI advisory reference to 'siehe Kritik'. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2 participants
Closes #671. The last of the personality-model cluster.
Gate result: DISC passes (like MBTI)
Viability test: "describe this person's communication style" → generic prose; "…using DISC" → the model imposes the four-quadrant D/I/S/C frame and classifies a profile. Output structure changes → utility present, so DISC is admitted — at tier ★☆☆ with an
:advisory:flag, the same treatment as MBTI (a weak-validity typology that nonetheless restructures output).What's in it
disc-modelanchor. Modern D/I/S/C and Marston's original terms (Dominance/Inducement/Submission/Compliance).:advisory:([Process Proposal]: How to handle anchors whose activated framing conflicts with their field's own consensus #624),:related:MBTI/Big Five/HEXACO; MBTI's:related:now includesdisc-model(bidirectional).The personality cluster under ADR-008 is now complete: Big Five (#673), HEXACO (#674), DISC (#671) added; MBTI held to the gate (#683); WEIRD closed (#675).
🤖 Generated with Claude Code
Summary by CodeRabbit