Update to a newer Omero version that's proxied in LabKey's Artifactory#65
Conversation
bbimber
left a comment
There was a problem hiding this comment.
@labkey-jeckels @labkey-susanh this is working for me locally.
|
@bbimber This is failing tests because it's got a conflicting version of org.json classes. Looking at the jar files that it's including, there are a lot more than before the changes. @labkey-susanh did your changes end up with a similar overlap? It may be somewhat random in terms of which version of the org.json classes get loaded first JARs in this FB: JARs from develop: |
|
@labkey-jeckels Yes, that looks in line with the jars I got from this feature branch locally, though I've not verified exactly. |
|
I'll directly ask the omero people if there is a best practice template for a genuinely minimal omero Java client. The Labkey module uses the most basic of omero APIs. |
|
@labkey-susanh omero functionality works for me w/ this. |
|
Tests are happy (both automated and Ben's manual Omero validation), JARs seem reasonable, and we're now serving through our Artifactory and on a release version. Seems like we should be ready to merge. |
| } | ||
|
|
||
| BuildUtils.addLabKeyDependency(project: project, config: "implementation", depProjectPath: ":server:modules:LabDevKitModules:LDK", depProjectConfig: "apiJarFile") | ||
| external (group: 'org.openmicroscopy', name: 'omero-gateway', version: '5.6.3') |
There was a problem hiding this comment.
If the excludes are not being done, the comment above can be removed. I think we need to exclude the json jar as we've done in several other places in our build:
{
// exclude this because it gets in the way of our own JSON object implementations from server/api
exclude group: "org.json", module:"json"
}
Rationale
openmicroscopy.org is down, so try a new Artifactory-based proxying and update to an official release version of Omero artifacts
Changes