Use consistent versions for Commons Collections 4 and Google Protocol Buffers#67
Closed
labkey-jeckels wants to merge 1 commit into
Closed
Use consistent versions for Commons Collections 4 and Google Protocol Buffers#67labkey-jeckels wants to merge 1 commit into
labkey-jeckels wants to merge 1 commit into
Conversation
…Google Protocol Buffers
labkey-susanh
requested changes
Oct 20, 2020
| //excludes based on: https://github.com/glencoesoftware/omero-ms-core/blob/master/build.gradle | ||
| dependencies { | ||
| external "com.google.protobuf:protobuf-java:${googleProtocolBufVersion}" | ||
| external("org.apache.commons:commons-collections4:${commonsCollections4Version}") |
There was a problem hiding this comment.
I think the better way to do this, since these two jars are not actually used in the compilation (and we've got a slew of other jar files not accounted for in the jars.txt for this module), is to force the versions for these jars up in the root-level build.gradle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We don't want conflicting versions of libraries across modules.
https://teamcity.labkey.org/buildConfiguration/LabKey_Trunk_Premium_VerifyDependencies/1145949?
Related Pull Requests
Changes