Skip to content

Use consistent versions for Commons Collections 4 and Google Protocol Buffers #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
labkey-jeckels wants to merge 1 commit into from
Closed

Use consistent versions for Commons Collections 4 and Google Protocol Buffers #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions omerointegration/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ repositories {

//excludes based on: https://github.com/glencoesoftware/omero-ms-core/blob/master/build.gradle
dependencies {
external "com.google.protobuf:protobuf-java:${googleProtocolBufVersion}"
external("org.apache.commons:commons-collections4:${commonsCollections4Version}")
Copy link
Copy Markdown

@labkey-susanh labkey-susanh Oct 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the better way to do this, since these two jars are not actually used in the compilation (and we've got a slew of other jar files not accounted for in the jars.txt for this module), is to force the versions for these jars up in the root-level build.gradle.


external (group: 'org.openmicroscopy', name: 'omero-gateway', version: '5.6.3')
{
exclude group: 'OME'
Expand Down