feat: remove @synhaptein fork from falcor-http-datasource#1
Conversation
ardeois
requested review from
GuillaumeSalles,
ludovicthomas,
mchambaud and
synhaptein
|
This is a breaking change! |
ludovicthomas
left a comment
ludovicthomas
left a comment
There was a problem hiding this comment.
Nice work! LGTM. Not sure we had unit tests on that?
|
No we don't unfortunately |
This was used to have dynamic headers, but this could be handled by client directly. If you want dynamic headers, you could have an object with dynamic properties. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty for more details BREAKING CHANGE: `dynamicHeaders` is not supported anymore, use `headers` config instead
ardeois
force-pushed
the
remove-forked-dependencies
branch
from
6743fd3 to
bd0add2
Compare
|
@synhaptein @ludovicthomas Version updated, ready to merge and publish a new major version |
|
I just checked the diff, and it's ok for the dynamic headers, but we are loosing the 'status' property on failed that was retrieved from an existing fork (see Netflix/falcor-http-datasource@master...ajoslin:status-code-build). For more details on our current diff with master, please check Netflix/falcor-http-datasource@master...Mixgenius:landr_custom. |
|
Oh right good catch @ludovicthomas . This seems to be related to a discussion with @synhaptein yesterday, where removing falcor-router fork means we'll loose the status as well (for GET). |
|
arfff... Netflix/falcor-http-datasource#33 has never been merged :/ |
synhaptein
left a comment
synhaptein
left a comment
There was a problem hiding this comment.
Thx to @ludovicthomas, I totally missed the merged I did from a PR still pending on the netflix repo :/ sorry for that
|
Closing this PR until I find a solution for this |
3 participants
This was used to have dynamic headers, but this could be handled by
client directly. If you want dynamic headers, you could have an object
with dynamic properties.
See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty for more details