Errors: always use instance with status & all props from response#33
Open
ajoslin wants to merge 1 commit into
Open
Errors: always use instance with status & all props from response#33ajoslin wants to merge 1 commit into
ajoslin wants to merge 1 commit into
Conversation
ajoslin
force-pushed
the
status-code
branch
2 times, most recently
from
2b4511b to
acd29cb
Compare
ajoslin
changed the title
|
Great fix! I was about to implement it on my side... Hope it can be merged soon! It would fix Netflix/falcor#745 |
|
Hey guys, would be awesome to merge this, @ajoslin can you rebase your work against master maybe? Thx |
|
Hey! Just pinging for an update here? |
Author
|
I'm not sure how to merge this with the latest changes safely, unfortunately, and I'm not currently active on the project I was using this in. I don't think I'll be able to justify taking the time to rebase it. |
|
@ajoslin Okay, how can I help? |
Author
|
Thanks @Hagbarth -- we need to rebase this to the latest master and verify that it still works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves error handling:
.statusis always added to the error object.