Skip to content

add missing addStatusObserver to pendingCommandRecovery#25

Merged
ps2 merged 1 commit into
LoopKit:mainfrom
marionbarker:bugfix/dev-issue-2118
Jan 26, 2024
Merged

add missing addStatusObserver to pendingCommandRecovery#25
ps2 merged 1 commit into
LoopKit:mainfrom
marionbarker:bugfix/dev-issue-2118

Conversation

@marionbarker
Copy link
Copy Markdown
Collaborator

See Loop Issue LoopKit/Loop#2118 for description of the problem.

By comparing the OmniBLE DashUICoordinator.swift file and the OmniKit OmnipodUICoordinator.swift file, I observed a line missing in the OmniKit version.

By adding that line and repeating the Uncertain Comms test for Eros, I was able to demonstrate immediate recovery for Eros similar to that seen when testing with the DASH rPi for OmniBLE.

In other words:

  • Stimulate an uncertain comms using Eros pod, Medtronic Rileylink and Faraday bag
  • With this PR in place, when the Rileylink is removed from the Faraday bag, the Comms restored screen appeared immediately

@ps2
Copy link
Copy Markdown
Contributor

ps2 commented Jan 26, 2024

Thanks!

@ps2 ps2 merged commit 20383c0 into LoopKit:main Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants