feat(Channel): Support getting about with PageHeader#581
Merged
LuanRT merged 1 commit intoLuanRT:mainfrom Jan 18, 2024
Merged
Conversation
2 tasks
LuanRT
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #577.
Turns out that it is possible to get the about popup for user channels with a
PageHeaderheader, it's buried inrendererContext.commandContextthough, which usually only contains tracking data.In the mean time I've also realised that it is possible to get the channel avatar from the channel metadata, so while it's not in the header at least it is still available.
A lot of the structure here is pretty similar to the one in
ChannelTagline, so at some point it might be worth refactoring that out into it's own class, to reduce the duplicate code.