perf(ds4): optimize q5 fused verifier on AMD - #569
Merged
Conversation
davide221
force-pushed
the
codex/ds4-16k-amd-opt
branch
from
August 3, 2026 21:26
be20268 to
0208630
Compare
davide221
force-pushed
the
codex/ds4-q5-verifier
branch
from
August 4, 2026 10:17
5417326 to
e24ad65
Compare
This was referenced Aug 4, 2026
davide221
force-pushed
the
codex/ds4-q5-verifier
branch
from
August 12, 2026 15:01
e24ad65 to
4ce3b82
Compare
davide221
marked this pull request as ready for review
August 12, 2026 15:03
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 16 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 16 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 7 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
davide221
force-pushed
the
codex/ds4-q5-verifier
branch
from
August 12, 2026 19:39
b5d3515 to
3244b9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the first PR in the heterogeneous DeepSeek 4 performance stack.
Validation
Tested on an R9700 target with Strix Halo expert offload, four routed experts, q=5, and deterministic 128-token completions.
All 25 measured responses matched the expected SHA-256. The DeepSeek 4 GPU unit suite passed.
Reproduction
Run
harness/qualification/deepseek4/qualify_ds4_q5_amd.shwithTARGET_MODEL,DRAFT_MODEL, andHOTNESS_CSV. The qualifier records configuration, response hashes, timings, ROCm state, and memory use.