Skip to content

Feature/devfile disclaimer#167

Merged
grallewellyn merged 11 commits intodevelopfrom
feature/devfile-disclaimer
Apr 12, 2023
Merged

Feature/devfile disclaimer#167
grallewellyn merged 11 commits intodevelopfrom
feature/devfile-disclaimer

Conversation

@grallewellyn
Copy link
Member

Added the following disclaimer to create workspaces as per @gchang 's suggestion

DISCLAIMER: MAAP might change the way that we do workspace memory limits in the future, including restricting the memory that a user can allocate for their workspace.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wildintellect
Copy link
Collaborator

@grallewellyn should we mention a sensible upper limit, and put a line "As a courtesy to other users only increase this limit if your kernel keeps running out of memory and crashing. If you're not sure why your kernel is crashing please contact the development team"

PS: This won't be merged until after #166

@grallewellyn
Copy link
Member Author

@wildintellect I agree, but what if we change it slightly to "As a courtesy to other users only increase this limit if your kernel keeps running out of memory and crashing. If you're not sure why your kernel is crashing after increasing your workspace's memory limit, please contact the development team"

Bold is what I am suggesting to add

@wildintellect
Copy link
Collaborator

@grallewellyn what's the upper limit? I had suggested to some users not to go over 16 GB without asking.

@grallewellyn
Copy link
Member Author

@gchang has mentioned 32GB, but maybe he can provide more clarification. I am not sure if this is something we want to decide on now and add to this disclaimer, or leave the disclaimer more vague.

@wildintellect

@wildintellect
Copy link
Collaborator

I'd prefer we set a suggestion at minimum, which we can always change. Reason - users will go as big as they can (also there is a physical limit to the node).

@grallewellyn can you also rebase or merge develop into your branch to bring it up to date with our recent re-organization of the dir structure?

@wildintellect wildintellect added this to the V3 milestone Apr 7, 2023
@grallewellyn
Copy link
Member Author

@wildintellect Done.

I agree we should suggest a minimum. Should we be suggesting 16GB in the disclaimer for now? I tried changing the devfile to 16GB and 16Gb and the workspace fails to start. Should we be telling users to enter 15258Mi for memory?
Screenshot 2023-04-10 at 8 06 06 AM

@wildintellect
Copy link
Collaborator

@grallewellyn yes use whatever size units the platform requires, if Mi seems to be the only one that works go with that.

@grallewellyn
Copy link
Member Author

@wildintellect @rtapella Does this disclaimer look good?

@grallewellyn grallewellyn merged commit 83ad07d into develop Apr 12, 2023
@wildintellect wildintellect deleted the feature/devfile-disclaimer branch May 26, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants