[roda] Return database results with symbols instead of strings - #782
Merged
Conversation
Contributor
Author
|
/benchmark -f roda -t async-db |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
Contributor
Author
|
/benchmark -f roda -t crud |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
Contributor
Author
|
/benchmark -f roda --save |
Contributor
|
👋 |
Contributor
|
|
Reuse symbols instead of creating new strings everytime.
p8
force-pushed
the
roda/pg-symbol-results
branch
from
June 2, 2026 14:59
199d2bc to
1586bff
Compare
Contributor
Author
|
/benchmark -f roda --save |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
MDA2AV
approved these changes
Jun 2, 2026
p8
added a commit
to p8/HttpArena
that referenced
this pull request
Jul 14, 2026
MDA2AV#782)" Commit 76acc5c, which allowed Symbol#to_s to return a frozen string, showed a big performance regression on the async-db test. Maybe this is related to the change to return symbols instead of strings. This reverts commit c503a98.
MDA2AV
pushed a commit
that referenced
this pull request
Jul 17, 2026
#996) * Revert "[roda] Return database results with symbols instead of strings (#782)" Commit 76acc5c, which allowed Symbol#to_s to return a frozen string, showed a big performance regression on the async-db test. Maybe this is related to the change to return symbols instead of strings. This reverts commit c503a98. * Benchmark results: roda --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse symbols instead of creating new strings everytime.