Revert "[roda] Return database results with symbols instead of strings - #996
Merged
Conversation
Contributor
Author
|
/benchmark -f roda |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
MDA2AV#782)" Commit 76acc5c, which allowed Symbol#to_s to return a frozen string, showed a big performance regression on the async-db test. Maybe this is related to the change to return symbols instead of strings. This reverts commit c503a98.
p8
force-pushed
the
roda/revert-c503a98d07166a
branch
from
July 14, 2026 07:43
fba4756 to
98c935c
Compare
Contributor
Author
|
/benchmark -f roda --save |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
MDA2AV
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 76acc5c, which allowed Symbol#to_s to return a frozen string, showed a big performance regression on the async-db test.
Maybe this is related to the change to return symbols instead of strings.
This reverts commit c503a98.