Get global ocean resources and time steps based on mesh size#631
Merged
xylar merged 6 commits intoMPAS-Dev:mainfrom May 14, 2023
Merged
Get global ocean resources and time steps based on mesh size#631xylar merged 6 commits intoMPAS-Dev:mainfrom
xylar merged 6 commits intoMPAS-Dev:mainfrom
Conversation
Collaborator
Author
|
I'm still seeing hanging in my tests of this branch, similar to #629. In this case, it's for |
ce6e5d8 to
4344de0
Compare
1 task
Collaborator
Author
TestingI ran the All other tests are passing. |
d07ced3 to
3bbfd93
Compare
211b093 to
3626993
Compare
This is used to compute the number of MPI tasks based on the number of grid cells
We want to get the core count from either the estimated or exact core count and the time step from the minimum resolution.
This is because it may not work with the prescribed time intervals for the restart test.
3626993 to
fd68d99
Compare
Collaborator
Author
|
Retested on Chrysalis after merging #630 and rebasing. I'm seeing non-BFB results for the cosine bell on Chrysalis in addition to the 5 tests mentioned above. Differences are only for the QU60 test and are at roundoff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge switches many global ocean steps to getting the core count from either an estimate or exact number of cells in the mesh. Similarly, it switches to computing the time steps (both barotropic and baroclinic) from the minimum resolution of the mesh.
This work paves the way for generalized QU and icosahedral global ocean meshes.
Checklist
api.rst) has any new or modified class, method and/or functions listedTestingin this PR) any testing that was used to verify the changes