Skip to content

Add general QU and Icos meshes#632

Merged
xylar merged 2 commits intoMPAS-Dev:mainfrom
xylar:add-general-qu-mesh
May 14, 2023
Merged

Add general QU and Icos meshes#632
xylar merged 2 commits intoMPAS-Dev:mainfrom
xylar:add-general-qu-mesh

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented May 11, 2023

A user can set the resolution at setup or runtime with the qu_resolution config option in the global_ocean section.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added enhancement New feature or request ocean in progress This PR is not ready for review or merging labels May 11, 2023
@xylar xylar self-assigned this May 11, 2023
@xylar xylar changed the title Add general qu mesh Add general QU and Icos meshes May 11, 2023
@xylar
Copy link
Collaborator Author

xylar commented May 11, 2023

This builds off of #631 and #630, and can't really be tested until the LCRC server comes back online.

@xylar xylar force-pushed the add-general-qu-mesh branch from 0353817 to 3f25278 Compare May 13, 2023 21:00
@xylar xylar mentioned this pull request May 13, 2023
1 task
@xylar xylar force-pushed the add-general-qu-mesh branch from 3f25278 to 54b2b0e Compare May 13, 2023 22:26
@xylar
Copy link
Collaborator Author

xylar commented May 14, 2023

Testing

I ran QU and IcoswISC test cases (didn't try QUwISC and Icos, but they should work fine if the other 2 do) including mesh, init and performance on Chrysalis with Intel and OpenMPI.

Results are here:

/lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20230513/qu*_2/
/lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20230513/icoswisc*_2/

A user can set the resolution at setup or runtime with the
`qu_resolution` config option.
@xylar xylar force-pushed the add-general-qu-mesh branch from 54b2b0e to 510415d Compare May 14, 2023 05:14
@xylar xylar marked this pull request as ready for review May 14, 2023 06:13
@xylar
Copy link
Collaborator Author

xylar commented May 14, 2023

The QU and Icos meshes are too time consuming and take too many codes to build (because of the topography remapping step) to be feasible to add to any test suites. It doesn't seem useful to cache meshes, since the whole point of these meshes is that they are user configurable.

@xylar xylar merged commit 715a137 into MPAS-Dev:main May 14, 2023
@xylar xylar removed the in progress This PR is not ready for review or merging label May 14, 2023
@xylar xylar deleted the add-general-qu-mesh branch May 14, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ocean

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant