Merged
Conversation
Collaborator
Author
0353817 to
3f25278
Compare
3f25278 to
54b2b0e
Compare
Collaborator
Author
TestingI ran QU and IcoswISC test cases (didn't try QUwISC and Icos, but they should work fine if the other 2 do) including Results are here: |
A user can set the resolution at setup or runtime with the `qu_resolution` config option.
54b2b0e to
510415d
Compare
Collaborator
Author
|
The QU and Icos meshes are too time consuming and take too many codes to build (because of the topography remapping step) to be feasible to add to any test suites. It doesn't seem useful to cache meshes, since the whole point of these meshes is that they are user configurable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user can set the resolution at setup or runtime with the
qu_resolutionconfig option in theglobal_oceansection.Checklist
api.rst) has any new or modified class, method and/or functions listedTestingin this PR) any testing that was used to verify the changes