Remove old variable / import features#1407
Merged
Merged
Conversation
ang-zeyu
force-pushed
the
remove-variables-imports
branch
from
dfb5164 to
360050c
Compare
4 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Resolves #1353
Overview of changes:
<variable>,<import>s<variable>sAnything you'd like to highlight / discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Remove old variable and import features
Page and s require processing html before nunjucks
and markdown. This poses several architectural issues of simplicity and
performance outlined in #1353.
Since these features now have viable alternatives, let's remove them.
Checklist: ☑️