Skip to content

Removing old variables using Nunjucks tag#2290

Closed
bibhu107 wants to merge 3 commits into
MarkBind:masterfrom
bibhu107:master
Closed

Removing old variables using Nunjucks tag#2290
bibhu107 wants to merge 3 commits into
MarkBind:masterfrom
bibhu107:master

Conversation

@bibhu107

@bibhu107 bibhu107 commented Apr 16, 2023

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:
Removed using Variables keyword started using Nunjucks tag. Taken reference from #1407

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Removing old variables using Nunjucks tag


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@tlylt

tlylt commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

Thanks @bibhu107 for the work thus far, will get back on this PR once I have discussed the details with the dev team.

@tlylt

tlylt commented Apr 28, 2023

Copy link
Copy Markdown
Contributor

Hi @bibhu107, sorry for the delay and thank you for your contribution once again. This PR is not necessary as there is no need to change how a variable is declared within the _markbind/variables.md file. The root cause of the original issue is more complicated (to understand) and hence I will be closing this PR and tackling it myself.

Thank you once again and feel free to explore other issues if you are keen.

@tlylt tlylt closed this Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants