Fix Footer Issue On Medium Viewports#1692
Conversation
There was a problem hiding this comment.
Nice work @kaixin-hc 👍
Generally looks good. I've tried it out and it seems to have fixed the issue.
I believe only one of the expected test files needs to be updated. The rest of the changes in the other test files can be stashed as they are not relevant to the PR.
| footer { | ||
| margin-left: 60px; | ||
| } | ||
| } |
There was a problem hiding this comment.
Only the changes in this file need to be committed as modifying the css file, packages/core/template/default/stylesheets/main.css, will only affect this test file.
There was a problem hiding this comment.
Thanks for checking this for me! I've reverted and pushed changes to just that file.
This reverts commit 4cfade7.
|
Thank you for updating :) It looks good! Sorry missed this out earlier, seems like the css for the documentation site has the same issue.
While you are at it, able to also remove the |
|
Sorry, for the wait, I've removed it! |
2 participants
What is the purpose of this pull request?
Fixes #1634
Overview of changes:
Remove the margin-left of the footer in the default CSS template.
Anything you'd like to highlight / discuss:
Testing instructions:
Run
markdown initand resize the viewport; there should be no left margin for the footer at any point.Proposed commit message: (wrap lines at 72 characters)
Checklist: ☑️