Skip to content

Fix Footer Issue On Medium Viewports #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonahtanjz merged 6 commits into from
Dec 19, 2021
Merged

Fix Footer Issue On Medium Viewports #1692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f916137
Fix Footer Issue On Medium Viewports
kaixin-hc Dec 16, 2021
6747b68
Remove margin-left specification for consistency
kaixin-hc Dec 16, 2021
4cfade7
Update tests to pass CI
kaixin-hc Dec 16, 2021
79f6184
Revert "Update tests to pass CI"
kaixin-hc Dec 17, 2021
fde2911
Modify test file to reflect changes
kaixin-hc Dec 17, 2021
b568bae
Fix docs CSS to remove margin space
kaixin-hc Dec 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions docs/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,6 @@ mark {
#site-nav {
display: none;
}

footer {
margin-left: 60px;
}
}

/* Bootstrap small(sm) responsive breakpoint */
Expand All @@ -132,10 +128,6 @@ mark {
#site-nav {
display: none;
}

footer {
margin-left: 0;
}
}

/* Hide site navigation when printing */
Expand Down
8 changes: 0 additions & 8 deletions packages/cli/test/functional/test_site_templates/test_default/expected/stylesheets/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,6 @@ mark {
#site-nav {
display: none;
}

footer {
margin-left: 60px;
}
}

@jonahtanjz jonahtanjz Dec 16, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the changes in this file need to be committed as modifying the css file, packages/core/template/default/stylesheets/main.css, will only affect this test file.

@kaixin-hc kaixin-hc Dec 17, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking this for me! I've reverted and pushed changes to just that file.


/* Bootstrap small(sm) responsive breakpoint */
Expand All @@ -132,10 +128,6 @@ mark {
#site-nav {
display: none;
}

footer {
margin-left: 0;
}
}

/* Hide site navigation when printing */
Expand Down
8 changes: 0 additions & 8 deletions packages/core/template/default/stylesheets/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,6 @@ mark {
#site-nav {
display: none;
}

footer {
margin-left: 60px;
}
}

/* Bootstrap small(sm) responsive breakpoint */
Expand All @@ -132,10 +128,6 @@ mark {
#site-nav {
display: none;
}

footer {
margin-left: 0;
}
}

/* Hide site navigation when printing */
Expand Down