Fix MarkBind internal package dependencies#1848
Conversation
jonahtanjz
left a comment
There was a problem hiding this comment.
Thanks @tlylt!
Not sure if
packages/core-web/package.json's dev dep onvue-componentsneeds to be adjusted as well (may not be necessary).
Don't think it's necessary but for consistency I think we should remove it as well.
Will also need to update the developer guide for doing a release. Usually these versions are incremented using the command lerna version --no-push (see step 2), which automatically adds in the ^. Will have to include the --exact option so that future releases will exclude the ^ as well.
Updated accordingly here. |
What is the purpose of this pull request?
Overview of changes:
Fixes #1845
Anything you'd like to highlight / discuss:
Not sure if
packages/core-web/package.json's dev dep onvue-componentsneeds to be adjusted as well (may not be necessary).Testing instructions:
nil
Proposed commit message: (wrap lines at 72 characters)
Ensure the referenced versions of MarkBind packages are exact
The use of range versions for internal packages results in
incorrect versioning of MarkBind packages when using an
older version of MarkBind.
Let's remove the compatible versioning and use the exact match.
This ensures the versions of internal packages downloaded
will be exact and provide the expected functionalities.
Checklist: ☑️