Skip to content

Fix MarkBind internal package dependencies #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonahtanjz merged 2 commits into from
Mar 23, 2022
Merged

Fix MarkBind internal package dependencies #1848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2440d3f
Update dep
tlylt Mar 22, 2022
938d18b
Update dev docs
tlylt Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions docs/devGuide/projectManagement.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,12 @@ For general best practices, refer to the guide [_Working with PRs_ @SE-EDU](http

1. **Make sure to start with a "clean slate"** by running `lerna clean` and then `npm run setup` in the root MarkBind directory.

1. **Increment the version number** by running `lerna version --no-push`. Which to increment (`patch`, `minor` or `major`) depends on what PRs are merged for the new version, which means you must know beforehand about the changes.
1. **Increment the version number** by running `lerna version --no-push --exact`. Which to increment (`patch`, `minor` or `major`) depends on what PRs are merged for the new version, which means you must know beforehand about the changes.

<box type="info" seamless>

The end result of this command is version commit with an appropriate tag. We will make use of the generated tag and commit message later.

* We will specify updated version numbers exactly to ensure that each version will consistently fetch the same versioned internal packages.
* The end result of this command is version commit with an appropriate tag. We will make use of the generated tag and commit message later.
</box>

1. **Build the core-web package bundle** by executing `npm run build:web` in the root directory, after which you should see changes in the bundles located in `packages/core-web/dist`. <br><br>Take a peek at the diff for the bundles to see if there are any strange changes.
Expand Down
4 changes: 2 additions & 2 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
"updatetest": "cd test/functional && node updatetest.js"
},
"dependencies": {
"@markbind/core": "^3.1.1",
"@markbind/core-web": "^3.1.1",
"@markbind/core": "3.1.1",
"@markbind/core-web": "3.1.1",
"bluebird": "^3.7.2",
"chalk": "^3.0.0",
"cheerio": "^0.22.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/core-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"@babel/plugin-transform-runtime": "^7.10.5",
"@babel/preset-env": "^7.10.4",
"@babel/runtime": "^7.10.5",
"@markbind/vue-components": "^3.1.1",
"@markbind/vue-components": "3.1.1",
"babel-loader": "^8.1.0",
"bootstrap-vue": "^2.16.0",
"cross-env": "^7.0.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@fortawesome/fontawesome-free": "^5.15.4",
"@markbind/core-web": "^3.1.1",
"@markbind/core-web": "3.1.1",
"@primer/octicons": "^15.0.1",
"@sindresorhus/slugify": "^0.9.1",
"bluebird": "^3.7.2",
Expand Down