Adapt constants files to TypeScript#1942
Closed
ryoarmanda wants to merge 2 commits into
Closed
Conversation
ang-zeyu
approved these changes
Jun 10, 2022
ang-zeyu
left a comment
ang-zeyu
left a comment
Contributor
There was a problem hiding this comment.
Lgtm 👍 : )
Although not sure if there's anything else you want to add since its still a draft.
For this PR in particular, I think we could use a rebase (without squash) to forcibly preserve history instead, as it dosen't seem like any amount of --rename-threshold would work.
Contributor
|
@ryoarmanda can you email me from your non-NUS email? I tried contacting you via slack and NUS email but there was no reply. |
Contributor
|
Closing for now due to #1987. |
ang-zeyu
added a commit
that referenced
this pull request
Sep 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Part of #1913
Overview of changes:
Adapt three constants files to TypeScript
Anything you'd like to highlight/discuss:
N/A
Testing instructions:
npm testchecks will doProposed commit message: (wrap lines at 72 characters)
Adapt constants files to TypeScript
Checklist: ☑️