Reorganize constants in packages/core#1987
Merged
Merged
Conversation
ang-zeyu
approved these changes
Aug 6, 2022
ang-zeyu
left a comment
Contributor
There was a problem hiding this comment.
I feel that re-evaluating the existing constants and shifting them into appropriate locations could help reduce unnecessary exports and set the stage for further refactoring. There could be personal preference involved so up for discussion on whether this PR improves the codebase.
Agreed here, this reorganization looks good! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
An initial attempt to refactor existing code within
packages/core. To keep changes manageable and easy to review, this PR only addresses the following:Anything you'd like to highlight/discuss:
Previously, an attempt was made to separate constants into individual files in #949. While there is nothing wrong with the approach, I feel that re-evaluating the existing constants and shifting them into appropriate locations could help reduce unnecessary exports and set the stage for further refactoring. There could be personal preference involved so up for discussion on whether this PR improves the codebase.
Testing instructions:
nil, this refactor should not affect existing functionalities and hence CI checks should be sufficient
Proposed commit message: (wrap lines at 72 characters)
Reorganize constants in packages/core
Checklist: ☑️