Skip to content

Migrate Markdown_it_icons.test to TypeScript#2480

Merged
kaixin-hc merged 2 commits into
MarkBind:masterfrom
yiwen101:markdown-it-icons_test_ts
Apr 4, 2024
Merged

Migrate Markdown_it_icons.test to TypeScript#2480
kaixin-hc merged 2 commits into
MarkBind:masterfrom
yiwen101:markdown-it-icons_test_ts

Conversation

@yiwen101

@yiwen101 yiwen101 commented Mar 29, 2024

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:
Quite straightforward and trivial changes. Working on #1913 .

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Migrate Markdown_it_icons.test to TypeScript


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

@codecov

codecov Bot commented Mar 29, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.11%. Comparing base (cab80b7) to head (16447bb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2480   +/-   ##
=======================================
  Coverage   51.11%   51.11%           
=======================================
  Files         124      124           
  Lines        5355     5355           
  Branches     1152     1152           
=======================================
  Hits         2737     2737           
  Misses       2328     2328           
  Partials      290      290           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yiwen101 yiwen101 force-pushed the markdown-it-icons_test_ts branch from 9c1b08e to 73cb637 Compare March 30, 2024 02:28

@jingting1412 jingting1412 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this, reminder to resolve any conflicts

@yiwen101 yiwen101 marked this pull request as draft April 3, 2024 09:46
@yiwen101 yiwen101 force-pushed the markdown-it-icons_test_ts branch from 63f22f8 to 16447bb Compare April 3, 2024 09:52
@yiwen101 yiwen101 marked this pull request as ready for review April 3, 2024 09:53
@yiwen101 yiwen101 mentioned this pull request Apr 3, 2024
14 tasks

@kaixin-hc kaixin-hc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kaixin-hc kaixin-hc merged commit 469ffe7 into MarkBind:master Apr 4, 2024
@github-actions github-actions Bot added the r.Patch Version resolver: increment by 0.0.1 label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r.Patch Version resolver: increment by 0.0.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants