Skip to content

Migrate Markdown_it_icons.test to TypeScript #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaixin-hc merged 2 commits into from
Apr 4, 2024
Merged

Migrate Markdown_it_icons.test to TypeScript #2480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fc1e69
Rename markdown-it-icons.test.js to typescript
yiwen101 Mar 29, 2024
16447bb
Adapt markdown-it-icons.test.js to typescript
yiwen101 Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ packages/core/src/utils/*.js
packages/core/src/variables/*.js
packages/core/test/unit/**/*.js

# TODO: remove when migrated to TS
!markdown-it-icons.test.js

# Rules for pure JS files
packages/core/src/lib/markdown-it/patches/*
packages/core/src/lib/markdown-it/plugins/*
Expand Down
3 changes: 0 additions & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,4 @@ packages/core/src/utils/*.js
packages/core/src/variables/*.js
packages/core/test/unit/**/*.js

# TODO: remove when migrated to TS
!markdown-it-icons.test.js

# --- packages/core end ---
5 changes: 3 additions & 2 deletions .../core/test/unit/markdown-it-icons.test.js → .../core/test/unit/markdown-it-icons.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
const expectedOcticon = require('@primer/octicons')['git-pull-request'].toSVG();
import octicons from '@primer/octicons';
import markdownIt from '../../src/lib/markdown-it';

const markdownIt = require('../../src/lib/markdown-it');
const expectedOcticon = octicons['git-pull-request'].toSVG();

test('markdown-it-icons renders icon syntax correctly', () => {
const source = ':fab-font-awesome: :glyphicon-home: :octicon-git-pull-request: :mit-task-alt:';
Expand Down