Skip to content

Fix tagging documentation#689

Merged
yamgent merged 1 commit into
MarkBind:masterfrom
jamos-tay:filtertags-update
Feb 17, 2019
Merged

Fix tagging documentation#689
yamgent merged 1 commit into
MarkBind:masterfrom
jamos-tay:filtertags-update

Conversation

@jamos-tay

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Documentation update

What is the rationale for this request?

The tagging documentation was moved from tweakingThePageStructure to usingPlugins when #474 was merged, but the outdated documentation wasn't removed, probably due to when the documentation was reshuffled

What changes did you make? (Give an overview)

Removed outdated documentation and linked it to the new, correct one
Created a folder for documentation of plugins

@damithc

damithc commented Feb 11, 2019

Copy link
Copy Markdown
Contributor

See if this breaks the Syntax Cheat Sheet and the Full Syntax Reference pages.

@jamos-tay

Copy link
Copy Markdown
Contributor Author

My bad, this should be fixed

Comment thread docs/userGuide/syntax/tags.mbdf

@Chng-Zhi-Xuan Chng-Zhi-Xuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't see any glaring issues.

@yamgent yamgent added this to the v1.18.1 milestone Feb 15, 2019
@yamgent

yamgent commented Feb 15, 2019

Copy link
Copy Markdown
Member

@jamos-tay Need you to resolve the conflict

@jamos-tay

Copy link
Copy Markdown
Contributor Author

Rebased

@yamgent yamgent merged commit 2446275 into MarkBind:master Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants