docs: Update outdated plugin documentation#770
Merged
Conversation
yamgent
requested changes
Mar 16, 2019
yamgent
left a comment
yamgent
left a comment
Member
There was a problem hiding this comment.
siteConfiguration.mdstill shows the wrong way of using "tags" settings.- This part of the code may not be very clear that it is inside
"filterTags"?
markbind/docs/userGuide/plugins/filterTags.mbdf
Lines 125 to 136 in d1d46c0
Contributor
Author
|
Updated |
yamgent
requested changes
Mar 21, 2019
yamgent
left a comment
yamgent
left a comment
Member
There was a problem hiding this comment.
Apologies for the late review
jamos-tay
force-pushed
the
plugins-doc-fix
branch
from
66fd17d to
82cf51b
Compare
Contributor
Author
|
Updated, rebased |
yamgent
approved these changes
Mar 23, 2019
yamgent
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] Documentation update
What is the rationale for this request?
Somehow during the documentation restructuring the filterTags documentation was changed to the older, incorrect one (#474). It should be the one from #689.
What changes did you make? (Give an overview)
Replaced it with the newer one (#689)