Skip to content

Remove stray space from FA icon syntax example#708

Merged
yamgent merged 1 commit into
MarkBind:masterfrom
Xenonym:docs/fa-icon-example-remove-space
Feb 19, 2019
Merged

Remove stray space from FA icon syntax example#708
yamgent merged 1 commit into
MarkBind:masterfrom
Xenonym:docs/fa-icon-example-remove-space

Conversation

@Xenonym

@Xenonym Xenonym commented Feb 18, 2019

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Documentation update

As suggested by #680 (comment).

What is the rationale for this request?
The syntax example for Font Awesome icons has a stray space due to bold formatting. This can be misleading as users may interpret it as a literal space to be included when using FA icons.

image

What changes did you make? (Give an overview)
I removed the bold formatting in the above examples to remove the stray space.

Testing instructions:

  1. Check the documentation for FA icon fonts. The stray space should no longer be there.

@yamgent yamgent added this to the v1.19.1 milestone Feb 19, 2019
@yamgent yamgent merged commit 1686253 into MarkBind:master Feb 19, 2019
@Xenonym Xenonym deleted the docs/fa-icon-example-remove-space branch February 19, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants