tracing: log chosen tokio-console port in orchestrator-tracing#12785
Merged
Conversation
guswynn
force-pushed
the
log-tokio
branch
2 times, most recently
from
a5f6a60 to
78e1761
Compare
guswynn
changed the title
benesch
reviewed
May 31, 2022
1 task
Contributor
Author
|
@benesch now that the log-lines have the full names, this is much simpler now! |
benesch
approved these changes
Jun 1, 2022
Contributor
|
Looks beautiful! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runtimetostoraged, when @benesch's pr storage: create a separate service for each source #12770 rebases with this, the id will have to changeMotivation
Testing
Release notes
None