Skip to content

tracing: add identifying information to log prefixes in the process orchestrator#12793

Merged
guswynn merged 1 commit into
MaterializeInc:mainfrom
guswynn:better-log-prefixes
Jun 1, 2022
Merged

tracing: add identifying information to log prefixes in the process orchestrator#12793
guswynn merged 1 commit into
MaterializeInc:mainfrom
guswynn:better-log-prefixes

Conversation

@guswynn

@guswynn guswynn commented May 31, 2022

Copy link
Copy Markdown
Contributor

In #12785, @benesch and I realized that stuff can be cleaned up if we just make the log-prefix much more clear!

Motivation

  • This PR adds a feature that has not yet been specified.

Testing

  • This PR has adequate test coverage / QA involvement has been duly considered.

Release notes

None

@guswynn guswynn requested a review from benesch May 31, 2022 20:45
Comment thread src/orchestrator-tracing/src/lib.rs Outdated

@benesch benesch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much better! Ty!

Comment thread src/orchestrator-tracing/src/lib.rs Outdated
Comment thread src/ore/src/tracing.rs Outdated
@guswynn guswynn force-pushed the better-log-prefixes branch from 949cd8c to b27755e Compare May 31, 2022 23:28
@guswynn guswynn enabled auto-merge (rebase) May 31, 2022 23:28
@guswynn guswynn merged commit a9765b4 into MaterializeInc:main Jun 1, 2022
@guswynn guswynn deleted the better-log-prefixes branch June 1, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants