storage: read debezium transactional metadata from persist#12798
Closed
benesch wants to merge 2 commits into
Closed
storage: read debezium transactional metadata from persist#12798benesch wants to merge 2 commits into
benesch wants to merge 2 commits into
Conversation
PR MaterializeInc#12082 converted source tokens to thread-safe `Arc`s to be compatible with the TCP storage/compute boundary, but since MaterializeInc#12216 replaced the TCP boundary with persist we can go back to Rcs.
Resolve a TODO to read the Debezium transactional metadata source out of persist, rather than re-rendering the source. This PR will unblock creating a pod per source (MaterializeInc#12770), but it is blocked on reverting (MaterializeInc#12082), which is no longer necessary now that TCP boundary has been removed.
1 task
Contributor
|
first commit looks good to me, but note that it can be minimized by just changing the |
Contributor
|
Copying my comment from the other PR:
|
Contributor
Author
|
Superseded by #12805. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve a TODO to read the Debezium transactional metadata source out of
persist, rather than re-rendering the source.
This PR will unblock creating a pod per source (#12770), but it is
blocked on reverting (#12082), which is no longer necessary now that TCP
boundary has been removed.
Motivation
Testing
Tips for reviewer
Drop#12082 because Petros's PR has made Correctly shutdown sources onDrop#12082 unnecessary.DebeziumTransactionMetadatastruct so that it either stores the global ID of the transaction metadata source or the persist shard ID, depending on where in the codebase we are. This matches the approach taken forDataflowDesc. The reason the diff is so large is because converting fromSourceDesc<GlobalId>toSourceDesc<CollectionMetadata>involves a massive amount of boilerplate since theDebeziumTransactionMetadatastruct is nested so deeply. I factored the boilerplate intomap_storage_metadatamethods on each type, so it should be very mechanical to review.Release notes
This PR includes the following user-facing behavior changes: