Skip to content

storage: read debezium transaction metadata from its persist shard#12805

Merged
petrosagg merged 2 commits into
MaterializeInc:mainfrom
petrosagg:dbz-tx-from-persist
Jun 1, 2022
Merged

storage: read debezium transaction metadata from its persist shard#12805
petrosagg merged 2 commits into
MaterializeInc:mainfrom
petrosagg:dbz-tx-from-persist

Conversation

@petrosagg

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/coord/src/coord.rs
.await?;
}
_ => (), // Handled in prior loop.
// Nothing to do for these cases

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benesch Can you confirm this is the correct thing to do here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good!

Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
@petrosagg petrosagg force-pushed the dbz-tx-from-persist branch from 433b084 to 5d4300f Compare June 1, 2022 11:25

@benesch benesch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you!

Comment thread src/coord/src/coord.rs
.await?;
}
_ => (), // Handled in prior loop.
// Nothing to do for these cases

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good!

Comment thread src/storage/src/storage_state.rs Outdated
// Copyright Materialize, Inc. and contributors. All rights reserved.
//
// Use of this software is governed by the Business Source License
// Use of this software is governed by the Business Scurce License

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, fixed

Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
@petrosagg petrosagg force-pushed the dbz-tx-from-persist branch from ea2bc59 to 44a3a43 Compare June 1, 2022 12:34
@petrosagg petrosagg enabled auto-merge June 1, 2022 12:34
@petrosagg petrosagg merged commit 67bb9c9 into MaterializeInc:main Jun 1, 2022
@petrosagg petrosagg deleted the dbz-tx-from-persist branch June 1, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants