Update dogs3 dependency#24742
Merged
Merged
Conversation
petrosagg
reviewed
Jan 30, 2024
| trace, | ||
| |time| time.step_back(), | ||
| |time, antichain| { | ||
| antichain.insert(time.step_back()); |
Contributor
There was a problem hiding this comment.
This doesn't yet give us "precise" compaction as described by the description of this PR yet, right? Do we plan to do this in MZ?
Contributor
Author
There was a problem hiding this comment.
It does, it turns out. MZ's use is limited to Product<u64, PointStamp<u64>>, or whatever, and that happens to be a distributive lattice for which compaction by the meet of the frontier equals compaction by the frontier.
Contributor
Author
There was a problem hiding this comment.
We could update the logic to push in each coordinate stepped back independently, for idiomatic reasons, but math says that we don't need to do this.
Contributor
There was a problem hiding this comment.
Very interesting, thanks for the explanation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.